Skip to content

Commit d102b60

Browse files
authoredJan 10, 2025··
fix pages secret bulk copy (#7732)
1 parent ab92f83 commit d102b60

File tree

3 files changed

+25
-20
lines changed

3 files changed

+25
-20
lines changed
 

‎.changeset/many-boats-glow.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"wrangler": patch
3+
---
4+
5+
fix pages secret bulk copy

‎packages/wrangler/src/__tests__/pages/secret.test.ts

+18-18
Original file line numberDiff line numberDiff line change
@@ -540,10 +540,10 @@ describe("wrangler pages secret", () => {
540540

541541
await runWrangler(`pages secret bulk --project some-project-name`);
542542
expect(std.out).toMatchInlineSnapshot(`
543-
"🌀 Creating the secrets for the Pages project \\"some-project-name\\" (production)
544-
Finished processing secrets JSON file:
545-
✨ 2 secrets successfully uploaded"
546-
`);
543+
"🌀 Creating the secrets for the Pages project \\"some-project-name\\" (production)
544+
Finished processing secrets file:
545+
✨ 2 secrets successfully uploaded"
546+
`);
547547
expect(std.err).toMatchInlineSnapshot(`""`);
548548
});
549549

@@ -571,10 +571,10 @@ describe("wrangler pages secret", () => {
571571
);
572572

573573
expect(std.out).toMatchInlineSnapshot(`
574-
"🌀 Creating the secrets for the Pages project \\"some-project-name\\" (production)
575-
Finished processing secrets JSON file:
576-
✨ 2 secrets successfully uploaded"
577-
`);
574+
"🌀 Creating the secrets for the Pages project \\"some-project-name\\" (production)
575+
Finished processing secrets file:
576+
✨ 2 secrets successfully uploaded"
577+
`);
578578
expect(std.err).toMatchInlineSnapshot(`""`);
579579
});
580580

@@ -602,7 +602,7 @@ describe("wrangler pages secret", () => {
602602

603603
expect(std.out).toMatchInlineSnapshot(`
604604
"🌀 Creating the secrets for the Pages project \\"some-project-name\\" (production)
605-
Finished processing secrets JSON file:
605+
Finished processing secrets file:
606606
✨ 3 secrets successfully uploaded"
607607
`);
608608
expect(std.err).toMatchInlineSnapshot(`""`);
@@ -636,10 +636,10 @@ describe("wrangler pages secret", () => {
636636
);
637637

638638
expect(std.out).toMatchInlineSnapshot(`
639-
"🌀 Creating the secrets for the Pages project \\"some-project-name\\" (preview)
640-
Finished processing secrets JSON file:
641-
✨ 2 secrets successfully uploaded"
642-
`);
639+
"🌀 Creating the secrets for the Pages project \\"some-project-name\\" (preview)
640+
Finished processing secrets file:
641+
✨ 2 secrets successfully uploaded"
642+
`);
643643
expect(std.err).toMatchInlineSnapshot(`""`);
644644
});
645645

@@ -694,11 +694,11 @@ describe("wrangler pages secret", () => {
694694
);
695695

696696
expect(std.out).toMatchInlineSnapshot(`
697-
"🌀 Creating the secrets for the Pages project \\"some-project-name\\" (production)
698-
Finished processing secrets JSON file:
699-
✨ 0 secrets successfully uploaded
700-
"
701-
`);
697+
"🌀 Creating the secrets for the Pages project \\"some-project-name\\" (production)
698+
Finished processing secrets file:
699+
✨ 0 secrets successfully uploaded
700+
"
701+
`);
702702
expect(std.err).toMatchInlineSnapshot(`
703703
"X [ERROR] 🚨 7 secrets failed to upload
704704

‎packages/wrangler/src/pages/secret/index.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -224,14 +224,14 @@ export const secret = (secretYargs: CommonYargsArgv, subHelp: SubHelp) => {
224224
}),
225225
}
226226
);
227-
logger.log("Finished processing secrets JSON file:");
227+
logger.log("Finished processing secrets file:");
228228
logger.log(
229229
`✨ ${
230230
Object.keys(upsertBindings).length
231231
} secrets successfully uploaded`
232232
);
233233
} catch (err) {
234-
logger.log("Finished processing secrets JSON file:");
234+
logger.log("Finished processing secrets file:");
235235
logger.log(`✨ 0 secrets successfully uploaded`);
236236
throw new FatalError(
237237
`🚨 ${Object.keys(upsertBindings).length} secrets failed to upload`

0 commit comments

Comments
 (0)
Please sign in to comment.