Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for replay_protection for Magic transit IPsec tunnels #1710

Conversation

Sceptyre
Copy link
Contributor

@Sceptyre Sceptyre commented Apr 9, 2024

Description

This change modifies the struct used to marshal/unmarshal the Magic Transit IPsec tunnel API. This is simply to have parity with the Cloudflare API and to allow the terraform provider to be updated to support this attribute.

Has your change been tested?

Yes. I've updated the existing "List" and "Get" tests as well as added a dedicated test for this parameter. I've also tested this against my environment and confirmed it works against the production api.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

Copy link
Contributor

github-actions bot commented Apr 9, 2024

changelog detected ✅

@jacobbednarz jacobbednarz merged commit a8a9c9f into cloudflare:master Apr 10, 2024
10 checks passed
@github-actions github-actions bot added this to the v0.93.0 milestone Apr 10, 2024
Copy link
Contributor

This functionality has been released in v0.93.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2024
@Sceptyre Sceptyre deleted the magic-transit-ipsec-tunnel-replay-protection branch April 10, 2024 12:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants