Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MT / MWAN: Adds IPsec tunnel healthcheck direction & rate parameters #1503

Conversation

cehrig
Copy link
Contributor

@cehrig cehrig commented Feb 8, 2024

Description

This PR adds healthcheck direction and rate parameters to the Magic IPsec Healthcheck type.

Has your change been tested?

Updated tests & ran a test against an actual environment.

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

Copy link
Contributor

github-actions bot commented Feb 8, 2024

changelog detected ✅

@jacobbednarz
Copy link
Member

has the API schemas been updated for this? looks like https://developers.cloudflare.com/api/operations/magic-ipsec-tunnels-create-ipsec-tunnels is still missing the new fields.

@cehrig
Copy link
Contributor Author

cehrig commented Feb 22, 2024

@jacobbednarz
Copy link
Member

thanking you sir! 🍭

@jacobbednarz jacobbednarz merged commit c15d2fc into cloudflare:master Feb 23, 2024
9 of 10 checks passed
@github-actions github-actions bot added this to the v0.89.0 milestone Feb 23, 2024
github-actions bot pushed a commit that referenced this pull request Feb 23, 2024
Copy link
Contributor

This functionality has been released in v0.89.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants