Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperdrive: Password should be nested in Origin #1501

Merged
merged 3 commits into from Feb 12, 2024

Conversation

carlos-alberto
Copy link
Contributor

Update the Hyperdrive client to nest Password in Origin

Description

The docs for Hyperdrive are inconsistent with the API.

I asked in the discord and was pointed here as the best representation of this endpoint.

Has your change been tested?

Automated tests updated to reflect correct types.

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

Copy link
Contributor

github-actions bot commented Feb 8, 2024

changelog detected ✅

@OilyLime
Copy link
Contributor

OilyLime commented Feb 9, 2024

Opened a PR pointing at this branch: carlos-alberto#1

…d-fields

Hyperdrive: Enforce required on all string fields in HyperdriveConfigOrigin
@OilyLime
Copy link
Contributor

OilyLime commented Feb 9, 2024

@jacobbednarz Should be rolling out the fix to the public API spec early next week. For now, this PR reflects the correct state of the API and shouldn't be blocked on us updating the public docs.

@jacobbednarz jacobbednarz merged commit 71af65b into cloudflare:master Feb 12, 2024
10 checks passed
@jacobbednarz
Copy link
Member

thanks!

@github-actions github-actions bot added this to the v0.88.0 milestone Feb 12, 2024
github-actions bot pushed a commit that referenced this pull request Feb 12, 2024
@OilyLime
Copy link
Contributor

API spec changes are live. Secret is embedded in the Origin, and all the other fields are accurately represented as required.

Copy link
Contributor

This functionality has been released in v0.88.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants