Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CRUD support for Images Variants #1494

Merged
merged 9 commits into from Feb 5, 2024
Merged

Add CRUD support for Images Variants #1494

merged 9 commits into from Feb 5, 2024

Conversation

hwrdprkns
Copy link
Contributor

@hwrdprkns hwrdprkns commented Feb 4, 2024 •
edited

Description

Adds support for the Images Variants API.

Resolves #1495.

Has your change been tested?

  • Tested ListImageVariantDetails manually
  • Tested GetImageVariantDetails manually
  • Go Test

Types of changes

What sort of change does your code introduce/modify?

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@hwrdprkns hwrdprkns closed this Feb 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2024 •
edited

changelog detected ✅

@hwrdprkns hwrdprkns reopened this Feb 5, 2024
@hwrdprkns hwrdprkns marked this pull request as ready for review February 5, 2024 00:36
jacobbednarz
jacobbednarz reviewed Feb 5, 2024
View reviewed changes
images_variants.go Outdated Show resolved Hide resolved
jacobbednarz
jacobbednarz reviewed Feb 5, 2024
View reviewed changes
images_variants.go Outdated Show resolved Hide resolved
jacobbednarz
jacobbednarz requested changes Feb 5, 2024
View reviewed changes
Copy link
Member

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting very close! just a couple of minor updates and we're good to merge this one.

@hwrdprkns
Copy link
Contributor Author

@jacobbednarz Sounds good. Just made the updates - thanks for reviewing!

@jacobbednarz jacobbednarz merged commit ecaae34 into cloudflare:master Feb 5, 2024
10 checks passed
@github-actions github-actions bot added this to the v0.88.0 milestone Feb 5, 2024
github-actions bot pushed a commit that referenced this pull request Feb 5, 2024
Update CHANGELOG.md for #1494
cca23db
@hwrdprkns
Copy link
Contributor Author

Thank you!

@github-actions GitHub Actions
Copy link
Contributor

This functionality has been released in v0.88.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacobbednarz jacobbednarz jacobbednarz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.88.0
Development

Successfully merging this pull request may close these issues.

Add Support for Images Variants
2 participants
@hwrdprkns @jacobbednarz