Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flarectl: fix duplicate alias in zone subcommand #1484

Merged
merged 1 commit into from Jan 19, 2024

Conversation

thomasqueirozb
Copy link
Contributor

@thomasqueirozb thomasqueirozb commented Jan 18, 2024

Fixes: #1465

Description

check and certs were both aliased to "c". Changed certs alias from "c" to "ct".

This would've been way more easier to debug if a log were introduced before os.Exit(1). I'd be happy to add it here but I'm unsure if not logging is the intended behavior.

err := app.Run(os.Args)
if err != nil {
os.Exit(1)
}

Just checked v0.82.0 where the zone command worked and zone c use the create command instead of the certs command. It looks like the c alias was changed from certs to create since the create command was added (d0f7110 )

Has your change been tested?

Yes, flarectl zone now works

Screenshots (if appropriate):

Not appropriate

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

Copy link
Contributor

github-actions bot commented Jan 18, 2024

changelog detected ✅

check and certs were both aliased to "c"
@jacobbednarz
Copy link
Member

This would've been way more easier to debug if a log were introduced before os.Exit(1). I'd be happy to add it here but I'm unsure if not logging is the intended behavior.

this is an unfortunate side effect of the design of the CLI tool here. all errors end up caught here and duplicated in the output since the commands will return an error.

thanks for fixing this one!

@jacobbednarz jacobbednarz merged commit d3e11bb into cloudflare:master Jan 19, 2024
11 checks passed
@github-actions github-actions bot added this to the v0.87.0 milestone Jan 19, 2024
github-actions bot pushed a commit that referenced this pull request Jan 19, 2024
Copy link
Contributor

This functionality has been released in v0.87.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zone command group doesn't work in flarectl amd64 build of v0.83.0 github release
2 participants