From 46a79a1872d91e44386b77745b22b747eba369d9 Mon Sep 17 00:00:00 2001 From: Jacob Bednarz Date: Fri, 8 Mar 2024 09:57:43 +1100 Subject: [PATCH] s/List/Get --- access_mutual_tls_certificates.go | 10 +++++----- access_mutual_tls_certificates_test.go | 8 ++++---- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/access_mutual_tls_certificates.go b/access_mutual_tls_certificates.go index 9dbb81bb95..9d4e413b17 100644 --- a/access_mutual_tls_certificates.go +++ b/access_mutual_tls_certificates.go @@ -64,7 +64,7 @@ type AccessMutualTLSHostnameSettings struct { Hostname string `json:"hostname,omitempty"` } -type ListAccessMutualTLSHostnameSettingsResponse struct { +type GetAccessMutualTLSHostnameSettingsResponse struct { Response Result []AccessMutualTLSHostnameSettings `json:"result"` } @@ -228,11 +228,11 @@ func (api *API) DeleteAccessMutualTLSCertificate(ctx context.Context, rc *Resour return nil } -// ListAccessMutualTLSHostnameSettings returns all Access mTLS hostname settings. +// GetAccessMutualTLSHostnameSettings returns all Access mTLS hostname settings. // // Account API Reference: https://developers.cloudflare.com/api/operations/access-mtls-authentication-update-an-mtls-certificate-settings // Zone API Reference: https://developers.cloudflare.com/api/operations/zone-level-access-mtls-authentication-list-mtls-certificates-hostname-settings -func (api *API) ListAccessMutualTLSHostnameSettings(ctx context.Context, rc *ResourceContainer) ([]AccessMutualTLSHostnameSettings, error) { +func (api *API) GetAccessMutualTLSHostnameSettings(ctx context.Context, rc *ResourceContainer) ([]AccessMutualTLSHostnameSettings, error) { uri := fmt.Sprintf( "/%s/%s/access/certificates/settings", rc.Level, @@ -244,7 +244,7 @@ func (api *API) ListAccessMutualTLSHostnameSettings(ctx context.Context, rc *Res return []AccessMutualTLSHostnameSettings{}, fmt.Errorf("%s: %w", errMakeRequestError, err) } - var accessMutualTLSHostnameSettingsResponse ListAccessMutualTLSHostnameSettingsResponse + var accessMutualTLSHostnameSettingsResponse GetAccessMutualTLSHostnameSettingsResponse err = json.Unmarshal(res, &accessMutualTLSHostnameSettingsResponse) if err != nil { return []AccessMutualTLSHostnameSettings{}, fmt.Errorf("%s: %w", errUnmarshalError, err) @@ -269,7 +269,7 @@ func (api *API) UpdateAccessMutualTLSHostnameSettings(ctx context.Context, rc *R return []AccessMutualTLSHostnameSettings{}, fmt.Errorf("%s: %w", errMakeRequestError, err) } - var accessMutualTLSHostnameSettingsResponse ListAccessMutualTLSHostnameSettingsResponse + var accessMutualTLSHostnameSettingsResponse GetAccessMutualTLSHostnameSettingsResponse err = json.Unmarshal(res, &accessMutualTLSHostnameSettingsResponse) if err != nil { return []AccessMutualTLSHostnameSettings{}, fmt.Errorf("%s: %w", errUnmarshalError, err) diff --git a/access_mutual_tls_certificates_test.go b/access_mutual_tls_certificates_test.go index 353946f95f..44a00ab692 100644 --- a/access_mutual_tls_certificates_test.go +++ b/access_mutual_tls_certificates_test.go @@ -53,7 +53,7 @@ func TestAccessMutualTLSCertificates(t *testing.T) { mux.HandleFunc("/accounts/"+testAccountID+"/access/certificates", handler) - actual, _, err := client.ListAccessMutualTLSCertificates(context.Background(), testAccountRC, ListAccessMutualTLSCertificatesParams{}) + actual, _, err := client.GetAccessMutualTLSCertificates(context.Background(), testAccountRC, GetAccessMutualTLSCertificatesParams{}) if assert.NoError(t, err) { assert.Equal(t, want, actual) @@ -61,7 +61,7 @@ func TestAccessMutualTLSCertificates(t *testing.T) { mux.HandleFunc("/zones/"+testZoneID+"/access/certificates", handler) - actual, _, err = client.ListAccessMutualTLSCertificates(context.Background(), testZoneRC, ListAccessMutualTLSCertificatesParams{}) + actual, _, err = client.GetAccessMutualTLSCertificates(context.Background(), testZoneRC, GetAccessMutualTLSCertificatesParams{}) if assert.NoError(t, err) { assert.Equal(t, want, actual) @@ -277,7 +277,7 @@ func TestDeleteAccessMutualTLSCertificate(t *testing.T) { assert.NoError(t, err) } -func TestListAccessMutualTLSHostnameSettings(t *testing.T) { +func TestGetAccessMutualTLSHostnameSettings(t *testing.T) { setup() defer teardown() @@ -318,7 +318,7 @@ func TestListAccessMutualTLSHostnameSettings(t *testing.T) { mux.HandleFunc("/accounts/"+testAccountID+"/access/certificates/settings", handler) - actual, err := client.ListAccessMutualTLSHostnameSettings(context.Background(), testAccountRC) + actual, err := client.GetAccessMutualTLSHostnameSettings(context.Background(), testAccountRC) if assert.NoError(t, err) { assert.Equal(t, want, actual)