Cloudflare Pages Deploy a Hono site instructions could now use serveStatic from hono/cloudflare-pages

[kpalmvik]

Existing documentation URL(s)

Pages > Framework guides > Deploy a Hono site

What changes are you suggesting?

To serve static files using Hono, the following instructions are currently given in the documentation:

To serve static files like CSS, image or JavaScript files, add the following to your src/server.js/ts file:

app.get("/public/*", async (ctx) => {
 return await ctx.env.ASSETS.fetch(ctx.req.raw);
});

This will cause all the files in the public folder within dist to be served in your application.

Since honojs/hono#1273 was added to address honojs/hono#1264 last year it is now possible to instead write:

import { serveStatic } from "hono/cloudflare-pages";

...

app.use("/public/*", serveStatic());

Additionally, this prevents a TypeScript problem that occurs when following the steps in the current documentation:

'ctx.env.ASSETS' is of type 'unknown' ts(18046)

Additional information

No response

[yusukebe]

Hi @kpalmvik

Thank you for the issue and the comment honojs/hono#838 (comment) on the Hono repo.

You are right. We can now use serveStatic() instead of ctx.env.ASSETS.fetch. These (e.g, using esbuild) are old ways, so we have to create the document based on the current starter structure.

I would be able to work on it.

[kpalmvik]

@yusukebe Would renewing the Cloudflare Pages Hono framework documentation, as discussed in honojs/hono#838, remove the need to even mention serveStatic here?

If so, it probably makes sense to close this issue.

[yusukebe]

Would renewing the Cloudflare Pages Hono framework documentation, as discussed in honojs/hono#838, remove the need to even mention serveStatic here?

Yes! We can remove it.

If so, it probably makes sense to close this issue.

Closing this issue is okay. Shall we keep to discuss it on honojs/hono#838?