Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed25519 is not a drop-in replacement of crypto/ed25519 #132

Closed
3 tasks
bwesterb opened this issue Jul 2, 2020 · 5 comments
Closed
3 tasks

ed25519 is not a drop-in replacement of crypto/ed25519 #132

bwesterb opened this issue Jul 2, 2020 · 5 comments
Assignees
@armfazh
Labels
changesAPI PR changes the API of a package

Comments

@bwesterb
Copy link
Member

bwesterb commented Jul 2, 2020 •
edited

  • GetPublic -> Public
  • NewKeyFromSeed returns *KeyPair instead of PrivateKey
  • (check for others.)
@bwesterb
Copy link
Member Author

bwesterb commented Jul 2, 2020

@armfazh Fixing this would make it easier to copy code from Circl to our stdlib fork.

@claucece
Copy link
Contributor

claucece commented Jul 3, 2020

Sort of already discussed here: #109, and there is already a PR for some of this: #123

@bwesterb
Copy link
Member Author

bwesterb commented Jul 9, 2020

Would we want ed448 to be a drop-in replacement of ed25519 as well?

@armfazh armfazh linked a pull request Jul 14, 2020 that will close this issue
Refactoring ed25519 for compatibility with stdlib #141
Closed
@armfazh armfazh self-assigned this Jul 14, 2020
@armfazh armfazh added the changesAPI PR changes the API of a package label Jul 14, 2020
@armfazh armfazh mentioned this issue Jul 14, 2020
Merged
@chris-wood
Copy link
Contributor

chris-wood commented Nov 6, 2020 •
edited

@bwesterb can we close this issue now that #142 landed?

@bwesterb
Copy link
Member Author

bwesterb commented Nov 6, 2020

I just checked the API and it's a drop in replacement now!

@bwesterb bwesterb closed this as completed Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@armfazh armfazh

Labels
changesAPI PR changes the API of a package
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactoring ed25519 for compatibility with stdlib armfazh/circl
4 participants
@bwesterb @chris-wood @claucece @armfazh