Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous issues raised during review of Dilithium PR #114

Open
2 of 5 tasks
bwesterb opened this issue May 13, 2020 · 0 comments
Open
2 of 5 tasks

Miscellaneous issues raised during review of Dilithium PR #114

bwesterb opened this issue May 13, 2020 · 0 comments

Comments

@bwesterb
Copy link
Member

bwesterb commented May 13, 2020 •
edited

  • Does it negatively impact performance if we implement ShakeHash on AesStream to simplify the sampling code. (Due to esacape-to-heap allocations.)
  • How far to go to check keys for consistency
  • Document which files gen.go generates.
  • Reconsider code layout.
  • Use intenal/test when appropriate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bwesterb