Skip to content

Commit 9180c8b

Browse files
authoredApr 2, 2024··
chore(types): Deprecate supported_identifiers and remove supported_external_accounts (#3089)
None of these are used in their respective classes and `supported_external_accounts` is not inside `/environment` response
1 parent d422dae commit 9180c8b

File tree

4 files changed

+12
-6
lines changed

4 files changed

+12
-6
lines changed
 

‎.changeset/famous-plums-fold.md

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'@clerk/clerk-js': minor
3+
'@clerk/types': minor
4+
---
5+
6+
Deprecate `supported_identifiers` and remove `supported_external_accounts`.

‎packages/clerk-js/src/core/test/fixtures.ts

-3
Original file line numberDiff line numberDiff line change
@@ -204,9 +204,7 @@ export const createSignIn = (signInParams: Partial<SignInJSON> = {}, user: Parti
204204
identifier: signInParams.identifier,
205205
object: 'sign_in',
206206
second_factor_verification: signInParams.second_factor_verification,
207-
supported_external_accounts: signInParams.supported_external_accounts,
208207
supported_first_factors: signInParams.supported_first_factors,
209-
supported_identifiers: signInParams.supported_identifiers,
210208
supported_second_factors: signInParams.supported_second_factors,
211209
user_data: {
212210
first_name: user.first_name,
@@ -235,7 +233,6 @@ export const createSignUp = (signUpParams: Partial<SignUpJSON> = {}) => {
235233
optional_fields: signUpParams.optional_fields,
236234
phone_number: signUpParams.phone_number,
237235
required_fields: signUpParams.required_fields,
238-
supported_external_accounts: signUpParams.supported_external_accounts,
239236
unsafe_metadata: signUpParams.unsafe_metadata,
240237
unverified_fields: signUpParams.unverified_fields,
241238
username: signUpParams.username,

‎packages/types/src/json.ts

-2
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import type { SamlIdpSlug } from './saml';
1414
import type { SessionStatus } from './session';
1515
import type { SignInFirstFactor, SignInJSON, SignInSecondFactor } from './signIn';
1616
import type { SignUpField, SignUpIdentificationField, SignUpStatus } from './signUp';
17-
import type { OAuthStrategy } from './strategies';
1817
import type { BoxShadow, Color, EmUnit, FontWeight, HexColor } from './theme';
1918
import type { UserSettingsJSON } from './userSettings';
2019
import type { CamelToSnake } from './utils';
@@ -80,7 +79,6 @@ export interface SignUpJSON extends ClerkResourceJSON {
8079
optional_fields: SignUpField[];
8180
missing_fields: SignUpField[];
8281
unverified_fields: SignUpIdentificationField[];
83-
supported_external_accounts: OAuthStrategy[];
8482
username: string | null;
8583
first_name: string | null;
8684
last_name: string | null;

‎packages/types/src/signIn.ts

+6-1
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,9 @@ import type { AuthenticateWithWeb3Params } from './web3Wallet';
6363

6464
export interface SignInResource extends ClerkResource {
6565
status: SignInStatus | null;
66+
/**
67+
* @deprecated This attribute will be removed in the next major version
68+
*/
6669
supportedIdentifiers: SignInIdentifier[];
6770
supportedFirstFactors: SignInFirstFactor[];
6871
supportedSecondFactors: SignInSecondFactor[];
@@ -227,8 +230,10 @@ export interface SignInJSON extends ClerkResourceJSON {
227230
object: 'sign_in';
228231
id: string;
229232
status: SignInStatus;
233+
/**
234+
* @deprecated This attribute will be removed in the next major version
235+
*/
230236
supported_identifiers: SignInIdentifier[];
231-
supported_external_accounts: OAuthStrategy[];
232237
identifier: string;
233238
user_data: UserDataJSON;
234239
supported_first_factors: SignInFirstFactorJSON[];

0 commit comments

Comments
 (0)
Please sign in to comment.