Skip to content

Commit 57c983f

Browse files
authoredJan 24, 2025··
feat(clerk-js,localizations,types): Add sign in or up subtitle localizations (#4988)
1 parent bd96d6c commit 57c983f

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

45 files changed

+1530
-131
lines changed
 

‎.changeset/neat-jokes-remember.md

+7
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
'@clerk/localizations': patch
3+
'@clerk/clerk-js': patch
4+
'@clerk/types': patch
5+
---
6+
7+
Add `subtitleCombined` localizations to sign-in-or-up flow.

‎packages/clerk-js/src/ui/components/SignIn/SignInStart.tsx

+17-8
Original file line numberDiff line numberDiff line change
@@ -429,14 +429,23 @@ export function _SignInStart(): JSX.Element {
429429
<Card.Root>
430430
<Card.Content>
431431
<Header.Root showLogo>
432-
{isCombinedFlow ? (
433-
<Header.Title localizationKey={localizationKeys('signIn.start.titleCombined')} />
434-
) : (
435-
<>
436-
<Header.Title localizationKey={localizationKeys('signIn.start.title')} />
437-
<Header.Subtitle localizationKey={localizationKeys('signIn.start.subtitle')} />
438-
</>
439-
)}
432+
<Header.Title
433+
localizationKey={
434+
isCombinedFlow ? localizationKeys('signIn.start.titleCombined') : localizationKeys('signIn.start.title')
435+
}
436+
/>
437+
<Header.Subtitle
438+
localizationKey={
439+
isCombinedFlow
440+
? localizationKeys('signIn.start.subtitleCombined')
441+
: localizationKeys('signIn.start.subtitle')
442+
}
443+
sx={{
444+
'&:empty': {
445+
display: 'none',
446+
},
447+
}}
448+
/>
440449
</Header.Root>
441450
<Card.Alert>{card.error}</Card.Alert>
442451
{/*TODO: extract main in its own component */}

0 commit comments

Comments
 (0)