Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies to patch a critical vulnerability and add Node.js 14 support #78

Merged
merged 2 commits into from
Apr 4, 2022

Conversation

amirandalibi
Copy link
Contributor

This PR updates knex library to address a critical SQL injection vulnerability. This security issue was that Identifiers were escaped incorrectly as part of the MSSQL dialect, allowing attackers to craft a malicious query to the host DB.

as part of this PR I also updated pg to version 8 to support Node 14 and along that had to update pg-query-stream and postgres-migrations.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@amirandalibi amirandalibi added dependencies Pull requests that update a dependency file vulnerability security labels Mar 31, 2022
@amirandalibi amirandalibi self-assigned this Mar 31, 2022
@amirandalibi amirandalibi marked this pull request as ready for review March 31, 2022 21:26
Copy link
Member

@jjpaulino jjpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍕

@amirandalibi amirandalibi merged commit 271c96e into master Apr 4, 2022
@amirandalibi amirandalibi deleted the upgrade-dependencies branch April 4, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file security vulnerability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants