Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clap_complete_nushell): correctly handle commands whose short description is more than one line #5359

Merged
merged 2 commits into from Feb 16, 2024

Conversation

poliorcetics
Copy link
Contributor

Found while trying to add Nushell completions to jj.

Questions

I implemented it in clap_complete_nushell for now, but I could see it being useful in other shells, maybe it should be handled by StyledStr directly ?

@poliorcetics
Copy link
Contributor Author

f80166c: error Commit subject is too long, 99 exceeds the max length of 50
f80166c: error Line is too long, 99 exceeds the max length of 72

That's annoying to respect, even the Linux kernel doesn't mandate 50 characters anymore

@epage
Copy link
Member

epage commented Feb 16, 2024

I implemented it in clap_complete_nushell for now, but I could see it being useful in other shells, maybe it should be handled by StyledStr directly ?

While I've not always been good about this, I do try to keep the completions in line with each other.

As for StyledStr, that is too low level to care about policy like this.

@epage epage merged commit f2c4e6e into clap-rs:master Feb 16, 2024
22 checks passed
@poliorcetics poliorcetics deleted the ab/push-szymvyzpmnqx branch February 16, 2024 23:58
@poliorcetics
Copy link
Contributor Author

Thanks for the amazingly quick review! When you have time, could you make a release with the fix ?

@epage
Copy link
Member

epage commented Feb 17, 2024

4.5.1 should already be out with the fix

@poliorcetics
Copy link
Contributor Author

Ah, I missed it, thanks a lot !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants