Make clap logo background transparent #4968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
@epage thanks for the merge, cool, looks way better now! 🎉 |
|
Context: The reason I had it white was so it would show up properly on docs.rs dark theme. This new transparent logo is not visible with the dark theme. |
|
@pksunkara I just checked with the dark theme, it's visible for me with the dark theme in both Firefox and Chromium. Theme ayu is bit of a different story. If ayu matters, a proper fix to me would either be one file per theme (if supported/possible) or a light edge/contour around all edges. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The white square background at https://docs.rs/clap/latest/clap/ top left didn't look right to me, so I replaced white by transparency…
What do you think?