feat(help): Allow customizing terminal styling (unstable) #4843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Random fixes along the way - In one case the space after `tip:` was "colored" (won't matter until themeing is available) - One error case didn't color invalid values - Changed the args associated with invalid values to be `literal` rather than `warning` - Changed the required value count to be `good` - Changed the arg for invalid value counts to be `literal` (the actual count is `warning`)
For now, this is behind the `unstable-styles` feature as we verify this is what we want for clap-rs#3224
Because this doesn't have a full section after it, people might want to style it differently than other headers.
We can add a new style and default it to what it was split out of without a breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step towards #3234 while allowing collecting of feedback
Code size
master: 534.9KiBvia
cargo bloat --release --features cargo --example cargo-example