fix(lex): Deprecate unsound OsStrExt::split_at
#4802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blyxxyz
reviewed
Mar 28, 2023
| @@ -193,6 +193,7 @@ pub trait OsStrExt: private::Sealed { | |||
| /// assert_eq!("Per", first); | |||
| /// assert_eq!(" Martin-Löf", last); | |||
| /// ``` | |||
| #[deprecated(since = "4.1.0", note = "This is not sound for all `index`")] | |||
| fn split_at(&self, index: usize) -> (&OsStr, &OsStr); | |||
There was a problem hiding this comment.
Shouldn't this one also be marked unsafe? Technically a BC break, but that's ok given the time scale and circumstances.
There was a problem hiding this comment.
I'd rather just soon release a v0.5 with it removed. This is an intermediate release so it will work with clap v4.1.x (as master is already prepped for v4.2.x)
epage
added a commit
to epage/clap
that referenced
this pull request
Mar 28, 2023
This is a followup to comments on clap-rs#4802
|
Addressed the comments in #4803 Thanks for looking! |
epage
added a commit
to epage/clap
that referenced
this pull request
Mar 28, 2023
This is a followup to comments on clap-rs#4802
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also clarifies safety requirements throughout the code
OsStris nottransparentyet but effectively it isOsStrdoes have invariants to uphold, similar tostrFixes #4800