Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update bitflags dep to 2.0 #4771

Merged
merged 1 commit into from Mar 19, 2023

Conversation

nicholasbishop
Copy link
Contributor

No description provided.

@epage epage merged commit 4c05dfb into clap-rs:master Mar 19, 2023
22 checks passed
@nicholasbishop nicholasbishop deleted the bishop-update-bitflags branch March 19, 2023 01:27
@Pat-Lafon
Copy link

Happy to see dependencies getting updated though I was a bit surprised when clippy now reports that clap uses two different versions of bitflags:1.3.2, 2.0.2. This isn't bad afaik, just a nuisance.

@epage
Copy link
Member

epage commented Mar 23, 2023

I just noticed that. I'm considering downgrading until all our dependencies are on the new version.

@nicholasbishop
Copy link
Contributor Author

nicholasbishop commented Mar 23, 2023

For reference, the old bitflags version is pulled in like this:

bitflags v1.3.2
└── rustix v0.36.11
    └── is-terminal v0.4.5
        └── clap v4.1.12

The minimum Rust version in rustix is currently 1.48 (thanks Debian), and the minimum Rust version for bitflags 2.0 is 1.56.

@Pat-Lafon
Copy link

Would it make sense to warn on clippy::multiple-crate-versions?

@epage
Copy link
Member

epage commented Mar 23, 2023

Unsure what I'm doing wrong but I went back to an old commit and running

$ cargo clippy --all-targets -- -D clippy::multiple-crate-versions

doesn't produce warnings.

In #4781 I am adding cargo-deny but I'm leaving multiple versions as a warnings because of hermit-abi and windows-sys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants