Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Assessments query to differential #25

Open
KyleEvers opened this issue May 10, 2019 · 0 comments
Open

Change Assessments query to differential #25

KyleEvers opened this issue May 10, 2019 · 0 comments
Assignees
Labels
bug This issue or pull request addresses broken functionality

Comments

@KyleEvers
Copy link
Contributor

馃悰 Bug Report

The assessments findings is sending the entire database over, but it should be a differential. Because the quality of the data being sent has been in flux we have opted to send the entire database daily. This should be changed to a differential to only send over new/changed records in the daily feed.

See lines here
https://github.com/cisagov/cyhy-feeds/blob/develop/aws_jobs/cyhy-data-extract.py#L283-L286

The query should add

                '$gte': start_of_data_collection,
                '$lt': end_of_data_collection

Where the data being checked it the last modified date for the document.

@felddy felddy added this to To do in Cyber Hygiene (CyHy) Jun 21, 2019
@mcdonnnj mcdonnnj self-assigned this Jun 21, 2019
@mcdonnnj mcdonnnj moved this from To do to In progress in Cyber Hygiene (CyHy) Jun 21, 2019
@mcdonnnj mcdonnnj added bug This issue or pull request addresses broken functionality enhancement labels Jun 21, 2019
mcdonnnj pushed a commit that referenced this issue Dec 4, 2019
mcdonnnj pushed a commit that referenced this issue Dec 4, 2019
Add codeowners file with team OIS maintainers.
@mcdonnnj mcdonnnj added wontfix This issue will not be incorporated and removed wontfix This issue will not be incorporated labels Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
Cyber Hygiene (CyHy)
  
In progress
Development

No branches or pull requests

3 participants