Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bash syntax to consume env variable #36544

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Use bash syntax to consume env variable #36544

merged 2 commits into from
Dec 16, 2024
+15 −15

Conversation

ferozsalam
Copy link
Contributor

  • Also change the GitHub secret names

@ferozsalam ferozsalam added the release-note/misc This PR makes changes that have no direct user impact. label Dec 12, 2024
@ferozsalam ferozsalam temporarily deployed to release-base-images December 12, 2024 13:31 — with GitHub Actions Inactive
@auto-committer auto-committer bot temporarily deployed to release-base-images December 12, 2024 16:18 Inactive
@auto-committer auto-committer bot temporarily deployed to release-base-images December 13, 2024 10:11 Inactive
@auto-committer auto-committer bot temporarily deployed to release-base-images December 13, 2024 10:12 Inactive
@auto-committer auto-committer bot temporarily deployed to release-base-images December 13, 2024 10:16 Inactive
@auto-committer auto-committer bot temporarily deployed to release-base-images December 13, 2024 11:52 Inactive
@auto-committer auto-committer bot temporarily deployed to release-base-images December 13, 2024 12:52 Inactive
@ferozsalam
Copy link
Contributor Author

Successful docs-builder run: https://github.com/cilium/cilium/actions/runs/12300459820
Successful base image release build run: https://github.com/cilium/cilium/actions/runs/12313775378

@ferozsalam ferozsalam force-pushed the pr/feroz/change-ref-source branch from 87eed4b to f9df382 Compare December 16, 2024 11:24
@ferozsalam ferozsalam temporarily deployed to release-base-images December 16, 2024 11:25 — with GitHub Actions Inactive
ferozsalam and others added 2 commits December 16, 2024 11:29
@ferozsalam
Use bash syntax to consume env variable
4c62a23 
- Also change the GitHub secret names

Signed-off-by: Feroz Salam <feroz.salam@isovalent.com>
@ferozsalam
ci: update docs-builder
Loading
Loading status checks…
179fe98 
Signed-off-by: Cilium Imagebot <noreply@cilium.io>
@ferozsalam ferozsalam force-pushed the pr/feroz/change-ref-source branch from f9df382 to 179fe98 Compare December 16, 2024 11:30
@ferozsalam ferozsalam marked this pull request as ready for review December 16, 2024 11:30
@ferozsalam ferozsalam requested review from a team as code owners December 16, 2024 11:30
@ferozsalam
Copy link
Contributor Author

/test

@aanm aanm added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit a837c13 Dec 16, 2024
72 checks passed
@aanm aanm deleted the pr/feroz/change-ref-source branch December 16, 2024 12:12
This was referenced Dec 16, 2024
Merged
Merged
Merged
@cilium-release-bot cilium-release-bot bot mentioned this pull request Dec 18, 2024
Merged
@joestringer joestringer mentioned this pull request Jan 24, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer

@aanm aanm

@christarazi christarazi

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ferozsalam @joestringer @aanm