Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh: conformance-clustermesh: test with IPsec + BPF NodePort #36384

Merged
merged 1 commit into from
Dec 5, 2024
Merged

gh: conformance-clustermesh: test with IPsec + BPF NodePort #36384

merged 1 commit into from
Dec 5, 2024
+1 −4

Conversation

julianwiedmann
Copy link
Member

This combination is supported as of v1.16, so remove the stale comment and switch over config 3 to test it.

@julianwiedmann julianwiedmann added area/CI Continuous Integration testing issue or flake area/clustermesh Relates to multi-cluster routing functionality in Cilium. release-note/ci This PR makes changes to the CI. feature/ipsec Relates to Cilium's IPsec feature needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Dec 5, 2024
@julianwiedmann
Copy link
Member Author

/ci-clustermesh

@julianwiedmann
gh: conformance-clustermesh: test with IPsec + BPF NodePort

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
45c3fc9 
This combination is supported as of v1.16, so remove the stale comment
and switch over config 3 to test it.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann force-pushed the pr/jwi/main/ci-conformance-clustermesh-ipsec branch from 084fff7 to 45c3fc9 Compare December 5, 2024 09:09
@julianwiedmann julianwiedmann changed the title gh: conformance-clustermsh: test with IPsec + BPF NodePort gh: conformance-clustermesh: test with IPsec + BPF NodePort Dec 5, 2024
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann added the dont-merge/preview-only Only for preview or testing, don't merge it. label Dec 5, 2024
@julianwiedmann julianwiedmann marked this pull request as ready for review December 5, 2024 09:14
@julianwiedmann julianwiedmann requested review from a team as code owners December 5, 2024 09:14
@julianwiedmann julianwiedmann requested a review from brlbil December 5, 2024 09:14
@julianwiedmann
Copy link
Member Author

First run was successful, I'll give it a few more spins though.

giorio94
giorio94 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@julianwiedmann
Copy link
Member Author

First run was successful, I'll give it a few more spins though.

5 rounds and no problem, let's go.

@julianwiedmann julianwiedmann removed the dont-merge/preview-only Only for preview or testing, don't merge it. label Dec 5, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit 103e5d5 Dec 5, 2024
88 checks passed
@julianwiedmann julianwiedmann deleted the pr/jwi/main/ci-conformance-clustermesh-ipsec branch December 5, 2024 10:58
@gandro gandro mentioned this pull request Dec 9, 2024
Merged
6 tasks
@gandro gandro added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Dec 9, 2024
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Dec 10, 2024
This was referenced Dec 12, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giorio94 giorio94

@brlbil brlbil

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake area/clustermesh Relates to multi-cluster routing functionality in Cilium. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. feature/ipsec Relates to Cilium's IPsec feature release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@julianwiedmann @giorio94 @gandro