Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs, daemon: Deprecate high-scale ipcache mode #36373

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Dec 4, 2024

This feature never made it out of beta. It doesn't even have documentation and has zero known users to this day. It's however covered in CI and adding maintenance burden. Let's deprecate it and remove it in v1.18.

@pchaigno pchaigno added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. feature/high-scale-ipcache Relates to the high-scale ipcache feature. labels Dec 4, 2024
Artyop added a commit to Artyop/cilium that referenced this pull request Dec 4, 2024

Verified

This commit was signed with the committer’s verified signature.
Artyop Antony R.
Quarantine waiting for cilium#36373 before deleting the test
More on https://isovalent.slack.com/archives/C06KAGZBNRW/p1733326137735609

Signed-off-by: Antony Reynaud <antony.reynaud@isovalent.com>
@pchaigno pchaigno force-pushed the deprecate-high-scale-ipcache branch from 88fd1a8 to 190fbc4 Compare December 4, 2024 17:12
Artyop added a commit to Artyop/cilium that referenced this pull request Dec 4, 2024

Verified

This commit was signed with the committer’s verified signature.
Artyop Antony R.
Quarantine of high-scale IPCache test, fixing the flake documented in cilium#36323
Once this PR cilium#36373 deprecating the high-scale ipcache mode is merged, the test will be deleted

Signed-off-by: Antony Reynaud <antony.reynaud@isovalent.com>
Artyop added a commit to Artyop/cilium that referenced this pull request Dec 4, 2024

Verified

This commit was signed with the committer’s verified signature.
Artyop Antony R.
Quarantine of high-scale IPCache test, fixing the flake documented in cilium#36323
Once this PR cilium#36373 deprecating the high-scale ipcache mode is merged, the test will be deleted

Signed-off-by: Antony Reynaud <antony.reynaud@isovalent.com>
@hemanthmalla
Copy link
Member

@pchaigno sad to see this feature go :/

Artyop added a commit to Artyop/cilium that referenced this pull request Dec 5, 2024

Verified

This commit was signed with the committer’s verified signature.
Artyop Antony R.
Quarantine of high-scale IPCache test, fixing the flake documented in cilium#36323
Once this PR cilium#36373 deprecating the high-scale ipcache mode is merged, the test will be deleted

Signed-off-by: Antony Reynaud <antony.reynaud@isovalent.com>
Artyop added a commit to Artyop/cilium that referenced this pull request Dec 5, 2024

Verified

This commit was signed with the committer’s verified signature.
Artyop Antony R.
Quarantine of high-scale IPCache test, fixing the flake documented in cilium#36323
Once this PR cilium#36373 deprecating the high-scale ipcache mode is merged, the test will be deleted

Signed-off-by: Antony Reynaud <antony.reynaud@isovalent.com>
github-merge-queue bot pushed a commit that referenced this pull request Dec 5, 2024
Quarantine of high-scale IPCache test, fixing the flake documented in #36323
Once this PR #36373 deprecating the high-scale ipcache mode is merged, the test will be deleted

Signed-off-by: Antony Reynaud <antony.reynaud@isovalent.com>
@pchaigno
Copy link
Member Author

pchaigno commented Dec 5, 2024

@pchaigno sad to see this feature go :/

Yeah 😞 I had hoped we could turn it into something useful...

@pchaigno pchaigno force-pushed the deprecate-high-scale-ipcache branch from 190fbc4 to 5974c9d Compare December 5, 2024 11:28
@pchaigno pchaigno marked this pull request as ready for review December 5, 2024 11:29
@pchaigno pchaigno requested review from a team as code owners December 5, 2024 11:29
@pchaigno pchaigno requested review from qmonnet and ldelossa December 5, 2024 11:29
@pchaigno pchaigno enabled auto-merge December 5, 2024 12:24
@pchaigno pchaigno force-pushed the deprecate-high-scale-ipcache branch from 5974c9d to 740be47 Compare December 5, 2024 14:24
This feature never made it out of beta. It doesn't even have
documentation and has zero known users to this day. It's however covered
in CI and adding maintenance burden. Let's deprecate it and remove it in
v1.18.

Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
@pchaigno pchaigno force-pushed the deprecate-high-scale-ipcache branch from 740be47 to 1ef5a00 Compare December 6, 2024 14:39
@pchaigno
Copy link
Member Author

pchaigno commented Dec 6, 2024

/test

@ldelossa
Copy link
Contributor

ldelossa commented Dec 8, 2024

Would be nice to remove all the special case code like manual decap :-D

@pchaigno pchaigno added this pull request to the merge queue Dec 8, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 8, 2024
Merged via the queue into cilium:main with commit d1ec98c Dec 8, 2024
64 checks passed
@pchaigno pchaigno deleted the deprecate-high-scale-ipcache branch December 8, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/high-scale-ipcache Relates to the high-scale ipcache feature. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants