-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs, daemon: Deprecate high-scale ipcache mode #36373
Merged
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artyop
added a commit
to Artyop/cilium
that referenced
this pull request
Dec 4, 2024
Quarantine waiting for cilium#36373 before deleting the test More on https://isovalent.slack.com/archives/C06KAGZBNRW/p1733326137735609 Signed-off-by: Antony Reynaud <antony.reynaud@isovalent.com>
88fd1a8
to
190fbc4
Compare
Artyop
added a commit
to Artyop/cilium
that referenced
this pull request
Dec 4, 2024
Quarantine of high-scale IPCache test, fixing the flake documented in cilium#36323 Once this PR cilium#36373 deprecating the high-scale ipcache mode is merged, the test will be deleted Signed-off-by: Antony Reynaud <antony.reynaud@isovalent.com>
Artyop
added a commit
to Artyop/cilium
that referenced
this pull request
Dec 4, 2024
Quarantine of high-scale IPCache test, fixing the flake documented in cilium#36323 Once this PR cilium#36373 deprecating the high-scale ipcache mode is merged, the test will be deleted Signed-off-by: Antony Reynaud <antony.reynaud@isovalent.com>
@pchaigno sad to see this feature go :/ |
Artyop
added a commit
to Artyop/cilium
that referenced
this pull request
Dec 5, 2024
Quarantine of high-scale IPCache test, fixing the flake documented in cilium#36323 Once this PR cilium#36373 deprecating the high-scale ipcache mode is merged, the test will be deleted Signed-off-by: Antony Reynaud <antony.reynaud@isovalent.com>
Artyop
added a commit
to Artyop/cilium
that referenced
this pull request
Dec 5, 2024
Quarantine of high-scale IPCache test, fixing the flake documented in cilium#36323 Once this PR cilium#36373 deprecating the high-scale ipcache mode is merged, the test will be deleted Signed-off-by: Antony Reynaud <antony.reynaud@isovalent.com>
Yeah 😞 I had hoped we could turn it into something useful... |
190fbc4
to
5974c9d
Compare
qmonnet
approved these changes
Dec 5, 2024
5974c9d
to
740be47
Compare
This feature never made it out of beta. It doesn't even have documentation and has zero known users to this day. It's however covered in CI and adding maintenance burden. Let's deprecate it and remove it in v1.18. Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
740be47
to
1ef5a00
Compare
/test |
Would be nice to remove all the special case code like manual decap :-D |
ldelossa
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/high-scale-ipcache
Relates to the high-scale ipcache feature.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/minor
This PR changes functionality that users may find relevant to operating Cilium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature never made it out of beta. It doesn't even have documentation and has zero known users to this day. It's however covered in CI and adding maintenance burden. Let's deprecate it and remove it in v1.18.