-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump StateDB to v0.3.4 and refactor db command usages #36325
Conversation
87bbe4b
to
fcbf9fa
Compare
/test |
fcbf9fa
to
867ece5
Compare
/test |
867ece5
to
8a37edb
Compare
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
8a37edb
to
95d1ae9
Compare
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLI changes looks good
Bump to latest StateDB version with the new script commands and improved help. Signed-off-by: Jussi Maki <jussi@isovalent.com>
Switch to the "db/<subcmd>" schema in tests, e.g. "db insert" becomes "db/insert" and so on. This new schema for sub-commands gives much better experience with 'help'. Signed-off-by: Jussi Maki <jussi@isovalent.com>
Since the loadbalancer implementation is still experimental in v1.17, avoid confusion by not creating/registering the tables if not enabled. Add 'cell_test.go' that checks that the defaults won't cause failure during population since I messed up initially (ToTable() crashed when RWTable[T] was nil). Signed-off-by: Jussi Maki <jussi@isovalent.com>
Switch to same sub-command schema as in StateDB by flatting the lb-maps commands. This makes it much easier to discover the commands using 'help'. Remove the 'lb-maps cmp' command as the '* cmp' (cmp with retry) does the same thing now. Also since the new implementation is not ready for v1.17, avoid confusion by not registering the lb* commands if not enabled. Signed-off-by: Jussi Maki <jussi@isovalent.com>
95d1ae9
to
c526f3d
Compare
/test |
To improve the ergonomics of the 'help' command in cilium shell I've decided to avoid nested
sub-commands (e.g. "db show") and instead go for Plan 9 style flat "db/show" commands.
This way the 'help' command can list all the commands and 'help -v' can give extended help
for the commands.
This PR bumps StateDB to v0.3.4 which comes with the new style and refactors the usages
of the commands in tests and mentions in docs.
While at it, I changed also the experimental LB to use the same style and to modify it so it won't
register its tables or commands unless enabled to avoid confusion.
Help now looks like this:
And we now can get verbose help for the commands: