v1.16 Backports 2024-11-21 #36093
Merged
v1.16 Backports 2024-11-21 #36093
+101
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pippolo84
added
kind/backports
pippolo84
force-pushed
the
pr/v1.16-backport-2024-11-21-12-48
branch
from
c4c8ae8 to
ba2b78b
Compare
|
/test-backport-1.16 |
christarazi
approved these changes
Nov 21, 2024
|
This is hitting #36086 in CI |
|
The only (required) test failing (ci-ipsec-upgrade) is hitting #36086, so marking this ready to merge. |
pippolo84
added
the
ready-to-merge
|
I think the right call here is rebasing to pick up the fix, and re-run CI. |
[ upstream commit 658382a ] Add AllMatch function that returns true if the predicate evaluates to true for each element in the slice. Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
[ upstream commit 7e6195b ] When a new node is discovered, in case of a multi-devices environment, we loop over each neighbor discovery link to found the next hop IP for the given node. For each link, if a next hop is found, it is inserted in the related neighNextHopByNode4 map. In this setup, it is possible that a node is reachable only by a subset of the neighbor discovery links. This case should not be considered an error, as long as the node is reachable by at least one link. Therefore, the errors handling logic is changed to propagate an error only when it is not possible to find a next hop for any link. This also reduces the amount of memory used for joining all the strings related to the false error condition described above, besides reducing the amount of useless retry runs of the node-neighbor-link-updater controller. Fixes: #34020 Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
julianwiedmann
force-pushed
the
pr/v1.16-backport-2024-11-21-12-48
branch
from
ba2b78b to
d8ee97a
Compare
julianwiedmann
removed
the
ready-to-merge
|
/test-backport-1.16 |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this PR is merged, a GitHub action will update the labels of these PRs: