images: Use cilium-builder image instead of golang to build hubble #35697
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
learnitall
added
release-note/misc
learnitall
added
affects/v1.15
chancez
approved these changes
Nov 1, 2024
rolinh
approved these changes
Nov 4, 2024
|
/test |
1 similar comment
|
/test |
learnitall
force-pushed
the
pr/learnitall/cilium-hubble-arm
branch
2 times, most recently
from
d158baf to
f095a30
Compare
|
/test |
learnitall
force-pushed
the
pr/learnitall/cilium-hubble-arm
branch
from
f095a30 to
33de2ab
Compare
|
/test |
1 similar comment
|
/test |
|
hmmm eks test keeps failing. @learnitall do you wanna try rebasing and see if it helps? 💭 |
The hubble image currently uses the golang docker image within the build stage. This commit modifies the build stage to use the cilium-builder image instead which contains the necessary tooling to allow for arm64 builds in CI workflows that run on amd64 machines. See cilium#35351 and cilium#35324 for more context. Signed-off-by: Ryan Drew <ryan.drew@isovalent.com>
learnitall
force-pushed
the
pr/learnitall/cilium-hubble-arm
branch
from
33de2ab to
eb80c98
Compare
|
Just pushed a rebase @michi-covalent, let's see if that helps. |
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
2 tasks
jschwinger233
added
backport-pending/1.16
1 task
jschwinger233
added
backport-pending/1.15
github-actions
bot
added
backport-done/1.16
joestringer
added
backport-done/1.15
This was referenced Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hubble image currently uses the golang docker image within the build stage. This commit modifies the build stage to use the cilium-builder image instead which contains the necessary tooling to allow for arm64 builds in CI workflows that run on amd64 machines.
See #35351 and #35324 for more context.