Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPsec encrypt status JSON output. #30167

Merged
merged 3 commits into from
Jan 23, 2024
Merged

IPsec encrypt status JSON output. #30167

merged 3 commits into from
Jan 23, 2024
+374 −77

Conversation

viktor-kurchenko
Copy link
Contributor

@viktor-kurchenko viktor-kurchenko commented Jan 10, 2024 •
edited by nathanjsweet
Loading

Cilium agent encrypt status command refactored and JSON output support implemented.

The changes were requested in Cilium CLI PR: cilium/cilium-cli#2212 to improve encryption status parsing.

api/cli: Encryption status now includes rendering IPsec status in JSON.

@viktor-kurchenko viktor-kurchenko requested review from a team as code owners January 10, 2024 08:59
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 10, 2024
@viktor-kurchenko viktor-kurchenko marked this pull request as draft January 10, 2024 09:11
@viktor-kurchenko viktor-kurchenko marked this pull request as ready for review January 10, 2024 10:27
@viktor-kurchenko viktor-kurchenko requested a review from a team as a code owner January 10, 2024 10:27
@mhofstetter mhofstetter mentioned this pull request Jan 10, 2024
Merged
@pchaigno pchaigno requested review from rgo3 and removed request for pchaigno January 15, 2024 12:01
@nathanjsweet nathanjsweet added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jan 16, 2024
nathanjsweet
nathanjsweet requested changes Jan 16, 2024
View reviewed changes
Copy link
Member

@nathanjsweet nathanjsweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good, but it needs two things:

  1. A release-note block in your initial PR comment.
  2. An addition to to the upgrade guide outlining the change in the API.

@viktor-kurchenko viktor-kurchenko requested a review from a team as a code owner January 17, 2024 17:08
@viktor-kurchenko
Copy link
Contributor Author

Overall this looks good, but it needs two things:

  1. A release-note block in your initial PR comment.
  2. An addition to to the upgrade guide outlining the change in the API.

Done.

@nathanjsweet
Copy link
Member

/test

@viktor-kurchenko viktor-kurchenko removed the request for review from mhofstetter January 19, 2024 08:34
@viktor-kurchenko
Copy link
Contributor Author

/test

@viktor-kurchenko
Copy link
Contributor Author

/test

rgo3
rgo3 approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@rgo3 rgo3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, left some non-blocking codestyle/naming nits wrt the status "getters".

@julianwiedmann julianwiedmann added needs-backport/1.12 needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch and removed backport/1.12 backport/1.14 This PR represents a backport for Cilium 1.14.x of a PR that was merged to main. labels Jan 23, 2024
@giorio94 giorio94 mentioned this pull request Jan 23, 2024
Merged
5 tasks
@giorio94 giorio94 mentioned this pull request Jan 24, 2024
Merged
4 tasks
@github-actions github-actions bot added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.12 labels Jan 26, 2024
@joamaki joamaki mentioned this pull request Jan 30, 2024
Merged
28 tasks
@joamaki joamaki added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Jan 30, 2024
@joamaki joamaki mentioned this pull request Jan 31, 2024
Merged
17 tasks
@joamaki joamaki added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 labels Jan 31, 2024
@aanm aanm added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Jan 31, 2024
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Feb 7, 2024
This was referenced Feb 12, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanjsweet nathanjsweet

@asauber asauber

@learnitall learnitall

@rgo3 rgo3

Assignees
No one assigned
Labels
backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
No open projects
cilium v1.12.19
Status: Released
cilium v1.13.12
Status: Released
cilium v1.14.7
Status: Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@viktor-kurchenko @nathanjsweet @learnitall @asauber @rgo3 @joamaki @aanm @julianwiedmann @giorio94