-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panic on macOS 10.12 #841
Comments
So yes, I guess we might not "support" macOS 10.12 -- looks like that's been out of supported service for about 3 years at this point. If you can come up with a patch for it (and it doesn't add too much complexity) we'll consider fixing it. You can have a look at the file you referenced to get a feeling for what's going on. |
It would also be useful to understand what is in the /etc/localtime file - a debug output of the parsed zone file should be sufficient to figure out what is going on. @fralonra if you clone down the |
Thanks for all! I cloned the source code and found that the error was generated from: chrono/src/offset/local/tz_info/timezone.rs Line 174 in d147e9a
I've also tried |
Thanks @fralonra - could you show the |
Encountered the same issue on macOS 10.12.6. Ran
|
@test9753 would you be able to figure out a PR for this? I probably won't have time to look into it (and can't easily test), would be happy to answer questions you have and/or review your code. |
looks like we've run into this with our users as well. we recently updating some our dependencies and that included our use of flexi_logger switching from After some digging I've gotten it to reproduce, as it seems to depend on what time zone the system is, apparently it doesn't like certain ones? I'm normally Not sure if sharing the /etc/localtime would help? I can try to dig into it more to see if we can figure it out, as so far I don't know exactly why that timezone is giving chrono grief yet. |
I was unable to get a virtual machine with macOS running. If you could provide one of the timezone files that is problematic (or all files) that would be a great help. |
here's the compressed timezone file that /etc/localtime is symlinked to when I can reproduce the panic. The simple example above is what i was using. 0.4.19 doesn't panic but 0.4.20+ does if that's helpful. |
Thank you! 0.4.20 is when we started to parse the file in chrono instead of depending on libc. |
np! let me know if you need anything else, looks like we can't roll back to 0.4.19 easily anyway so a fix will be the best way forward. |
In case it's helpful, I poked around some with v0.4.26 tag source of chrono to compare modern macOS tz file vs the one from 10.11, looks like the extra_rule path is taken on newer macOS. The newer macOS tz file has extra_rule, a few more transitions & local_time_types too. If you need/want a newer macOS tz file for Guayaquil I can upload too. Also wish I could remember what I had to do to get the macOS 10.11 VM created, do recall it was a huge pain in the ass being such an old macOS. It's in Parallels on an intel mac I have for testing these kind of things, getting them running on a PC is even more of a pain too. |
thanks a ton for fixing it! going to give the 0.4.x branch a spin with our app now as that should likely fix the issue a few users were seeing! |
Let us know if it works 😄. |
oh it definitely does! thanks again! no more panic on the super old macOS systems. |
Hi, all.
The following minimum code panicked and I don't know why:
panic message:
from this line:
chrono/src/offset/local/unix.rs
Line 132 in 4514276
env
The text was updated successfully, but these errors were encountered: