Parsing negative NaiveDateTime timestamps with serde(with = "ts_milliseconds") fails

[ousado]

Parsing negative NaiveDateTime timestamps with #[serde(with = "ts_milliseconds")] (and other implementations) fails.

use chrono::{NaiveDateTime}; // 0.4.19
use chrono::naive::serde::ts_milliseconds::deserialize as from_milli_ts;
use serde::Deserialize;

#[derive(Deserialize)]
struct S {
  #[serde(deserialize_with = "from_milli_ts")]
  time: NaiveDateTime
}
        
fn example() -> Result<S, serde_json::Error> {
  let my_s: S = serde_json::from_str(r#"{ "time": -1 }"#)?;
  Ok(my_s)
}
        

fn main() {
    let value = -1;
    let r0 = value / 1000;
    let r1 = (value % 1000);
    // this is the implementation in chrono::naive::serde::ts_milliseconds
    let r = NaiveDateTime::from_timestamp_opt(   
        value / 1000, 
        ((value % 1000) * 1_000_000) as u32);  // conversion into u32 fails for negative values 
    println!("{:?} {} {}", r, r0, r1);
    example().unwrap();
}

[pitdicker]

Fixed in #1194.