Update windows-bindgen to 0.53 #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1462 +/- ##
=======================================
Coverage 92.11% 92.11%
=======================================
Files 40 40
Lines 18026 18026
=======================================
Hits 16604 16604
Misses 1422 1422 ☔ View full report in Codecov by Sentry. |
djc
approved these changes
Feb 26, 2024
| @@ -53,7 +53,7 @@ js-sys = { version = "0.3", optional = true } # contains FFI bindings for | |||
| windows-targets = { version = "0.52", optional = true } | |||
|
|
|||
| [target.'cfg(windows)'.dev-dependencies] | |||
| windows-bindgen = { version = "0.52" } | |||
| windows-bindgen = { version = "0.53" } # The MSRV of its windows-metatada 0.53 dependency is 1.70 | |||
There was a problem hiding this comment.
Since this is a dev-dependency, why is this comment useful?
There was a problem hiding this comment.
Because the version requirement bit me once 😄.
Just serving as documentation of the minimum rust version we need to do development on chrono on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1461. @dependabot can't update the version line in the generated file.
Version 0.53 now build with rust 1.70 instead of 1.73, and defines it as the MSRV microsoft/windows-rs#2766.