Small Windows cleanups #1441
Merged
Small Windows cleanups #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitdicker
force-pushed
the
windows_fixes
branch
from
2360f46
to
120bae1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1441 +/- ##
=======================================
Coverage 91.86% 91.86%
=======================================
Files 40 40
Lines 17471 17471
=======================================
Hits 16049 16049
Misses 1422 1422 ☔ View full report in Codecov by Sentry. |
pitdicker
force-pushed
the
windows_fixes
branch
2 times, most recently
from
3c6a5a4
to
9d9d0b3
Compare
pitdicker
force-pushed
the
windows_fixes
branch
from
9d9d0b3
to
92c227e
Compare
djc
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
Durationin a test on Windows. This is fine becauseDurationis an alias ofTimeDelta, but I had to switch it toTimeDeltato make the merge with 0.5.x. Better be consistent and useTimeDeltaeverywhere.This also fixes one Clippy warning in the Windows module, and sets up our CI to lint the Windows target. Apparently our CI wasn't doing that, despite
--all-targets.