Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify branch for GitHub Actions badge and fix link #1388

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

pitdicker
Copy link
Collaborator

I think it makes more sense for the GitHub Actions badge to match the latest run on the branch that that particular readme is on.
For the main branch I'll make it point to the main with the next merge.

This also fixes the link, that seems to have been broken for quite a while.

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (94f9738) 91.72% compared to head (850c55e) 91.72%.

❗ Current head 850c55e differs from pull request most recent head ab57b81. Consider uploading reports for the commit ab57b81 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1388   +/-   ##
=======================================
  Coverage   91.72%   91.72%           
=======================================
  Files          38       38           
  Lines       17267    17267           
=======================================
  Hits        15839    15839           
  Misses       1428     1428           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pitdicker pitdicker mentioned this pull request Jan 26, 2024
@pitdicker
Copy link
Collaborator Author

@djc Just saw your comment on switching the main branch. If we go that route we may only want to fix the link here.

@djc
Copy link
Contributor

djc commented Jan 26, 2024

See #1390, so this might need some changes?

@pitdicker pitdicker merged commit ec557d2 into chronotope:main Jan 26, 2024
35 checks passed
@pitdicker pitdicker deleted the gh_actions_badge branch January 26, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants