Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use deprecated method in impl Arbitrary for DateTime #1336

Merged
merged 3 commits into from Jan 26, 2024

Conversation

pitdicker
Copy link
Collaborator

@pitdicker pitdicker commented Oct 1, 2023

Missed in #1175. I also modified the CI to check the arbitrary feature.

@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (ec557d2) 91.72% compared to head (bdd6148) 91.72%.

Files Patch % Lines
src/month.rs 0.00% 2 Missing ⚠️
src/datetime/mod.rs 0.00% 1 Missing ⚠️
src/naive/datetime/mod.rs 0.00% 1 Missing ⚠️
src/offset/utc.rs 0.00% 1 Missing ⚠️
src/weekday.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1336   +/-   ##
=======================================
  Coverage   91.72%   91.72%           
=======================================
  Files          38       38           
  Lines       17267    17267           
=======================================
  Hits        15839    15839           
  Misses       1428     1428           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pitdicker pitdicker force-pushed the arbitrary branch 2 times, most recently from 4b27c91 to 21cc533 Compare October 1, 2023 13:57
@pitdicker
Copy link
Collaborator Author

It turns out arbitrary doesn't support no_std (see rust-fuzz/arbitrary#38, rust-fuzz/arbitrary#74).

Because there is a chance it may in the future, I thought it best to not make the arbitrary feature imply std, but to put our implementations behind an extra std feature gate.

@pitdicker
Copy link
Collaborator Author

Converted to draft for now. Maybe my comment in rust-fuzz/arbitrary#74 (comment) gets a reply.

@pitdicker pitdicker marked this pull request as ready for review January 26, 2024 14:37
@pitdicker
Copy link
Collaborator Author

This is a small PR that replaces the use of a deprecated method and sets up a CI test for the arbitrary feature. I don't think we need to wait any longer on seeing changes to arbitrary to merge this.

@pitdicker pitdicker merged commit baa55d0 into chronotope:main Jan 26, 2024
36 of 37 checks passed
@pitdicker pitdicker deleted the arbitrary branch January 26, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants