Make Display
format of Duration
conform better to ISO 8601
#1328
+29
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Display
format ofDuration
currently converts all values greater than 24 hours to a value with days. But in ISO 8601P1D
has a different meaning fromPT86400S
.If we get a duration type that properly supports the ISO 8601 format with different components (#1282), I think we should fix the simple
Duration
type to always write only seconds. We later may be able to share the parser and aFromStr
implementation.I ported the code to count the significant fractional digits in
nanos
from #1290.It should find a shared place once one of these PRs has landed.