Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: run tests on i686 and wasm32-wasi #1237

Merged
merged 6 commits into from Sep 1, 2023
Merged

Conversation

pitdicker
Copy link
Collaborator

Fixes #352.

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #1237 (34ca0b4) into 0.4.x (243d26d) will decrease coverage by 0.28%.
Report is 1 commits behind head on 0.4.x.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##            0.4.x    #1237      +/-   ##
==========================================
- Coverage   86.10%   85.82%   -0.28%     
==========================================
  Files          37       37              
  Lines       13522    13517       -5     
==========================================
- Hits        11643    11601      -42     
- Misses       1879     1916      +37     
Files Changed Coverage Δ
src/datetime/tests.rs 96.53% <ø> (ø)
src/offset/local/tz_info/timezone.rs 85.69% <66.66%> (-0.14%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

// Some targets, such as `wasm-wasi` have a problematic definition of `SystemTime`, such as an
// `i32` (year 2035 problem), or an `u64` (no values before `UNIX-EPOCH`).
// See https://github.com/rust-lang/rust/issues/44394.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I'd like the comments to go before the attributes, keeping the attributes right next to the code.

@djc
Copy link
Contributor

djc commented Aug 31, 2023

Does this also fix #1236?

@pitdicker
Copy link
Collaborator Author

No. I'll reply to that issue.

@pitdicker pitdicker force-pushed the ci_i686 branch 5 times, most recently from 15c5555 to b21d0d8 Compare August 31, 2023 09:18
@pitdicker pitdicker force-pushed the ci_i686 branch 2 times, most recently from 5ad87b1 to 6a12c1c Compare August 31, 2023 19:06
@pitdicker
Copy link
Collaborator Author

In the end I opted for using cross instead of installing the cross-compiling toolchains in Ubuntu on the CI.

This hit another problem: the test_time_zone_from_posix_tz test expects there to always be a timezone database available on Unix, but that is not true in the docker containers used by cross.

@djc Do you want to give it a second look?

@pitdicker
Copy link
Collaborator Author

I have no clue why codecov thinks our coverage in local/unix/timezone.rs has massively changed from 85.69% to 66.67%, while at the same time saying the change in that file is -0.14%.

For now codecov seems mostly trouble, but maybe we get some use out of it eventually...

@djc djc merged commit ecfad9e into chronotope:0.4.x Sep 1, 2023
36 of 37 checks passed
@djc
Copy link
Contributor

djc commented Sep 1, 2023

LGTM, thanks!

@pitdicker pitdicker deleted the ci_i686 branch September 1, 2023 10:12
@pitdicker pitdicker mentioned this pull request Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants