New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: run tests on i686
and wasm32-wasi
#1237
Conversation
Codecov Report
@@ Coverage Diff @@
## 0.4.x #1237 +/- ##
==========================================
- Coverage 86.10% 85.82% -0.28%
==========================================
Files 37 37
Lines 13522 13517 -5
==========================================
- Hits 11643 11601 -42
- Misses 1879 1916 +37
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
src/datetime/tests.rs
Outdated
// Some targets, such as `wasm-wasi` have a problematic definition of `SystemTime`, such as an | ||
// `i32` (year 2035 problem), or an `u64` (no values before `UNIX-EPOCH`). | ||
// See https://github.com/rust-lang/rust/issues/44394. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I'd like the comments to go before the attributes, keeping the attributes right next to the code.
Does this also fix #1236? |
No. I'll reply to that issue. |
15c5555
to
b21d0d8
Compare
5ad87b1
to
6a12c1c
Compare
In the end I opted for using This hit another problem: the @djc Do you want to give it a second look? |
I have no clue why codecov thinks our coverage in For now codecov seems mostly trouble, but maybe we get some use out of it eventually... |
LGTM, thanks! |
Fixes #352.