Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct documentation for FromStr for Weekday and Month #1226

Merged
merged 1 commit into from Aug 31, 2023

Conversation

wfraser
Copy link
Contributor

@wfraser wfraser commented Aug 25, 2023

The described parsing specifiers were wrong. Not that it actually uses those in the code, but their effect would be the same.

Relevant part of strftime docs:

Spec. Example Description
%B July Full month name. Also accepts corresponding abbreviation in parsing.
%A Sunday Full weekday name. Also accepts corresponding abbreviation in parsing.
%W 27 Same as %U, but week 1 starts with the first Monday in that year instead.

@djc djc changed the base branch from main to 0.4.x August 26, 2023 07:34
@djc djc changed the base branch from 0.4.x to main August 26, 2023 07:34
@djc
Copy link
Contributor

djc commented Aug 26, 2023

Thanks for fixing this up! Can you rebase this on 0.4.x, please?

@pitdicker
Copy link
Collaborator

Shall we merge this, and backport together with #1240?

@wfraser
Copy link
Contributor Author

wfraser commented Aug 31, 2023

Rebased on 0.4.x

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #1226 (558eff6) into main (7eb6db1) will increase coverage by 0.18%.
Report is 110 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1226      +/-   ##
==========================================
+ Coverage   86.14%   86.32%   +0.18%     
==========================================
  Files          37       35       -2     
  Lines       13394    13896     +502     
==========================================
+ Hits        11538    11996     +458     
- Misses       1856     1900      +44     
Files Changed Coverage Δ
src/format/mod.rs 76.47% <ø> (+1.10%) ⬆️

... and 21 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pitdicker pitdicker changed the base branch from main to 0.4.x August 31, 2023 20:16
@pitdicker pitdicker merged commit f9d231b into chronotope:0.4.x Aug 31, 2023
36 checks passed
@pitdicker
Copy link
Collaborator

Rebased on 0.4.x

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants