tests: date path consolidate (branch 0.4.x) #1090

jtmoon79 · 2023-05-28T04:50:30Z

Consolidate date_path.
Sanity check date can run date --version before attempting to use it.
Print test progress messages.

jtmoon79 · 2023-05-28T05:00:57Z

Relates to #1060

Sanity check `date` command used in tests `try_verify_against_date_command` and `try_verify_against_date_command_format`. Make sure it's the kind of `data` command expected (accepts `--version`). Also, it's just good to print this for debugging purposes.

jtmoon79 · 2023-05-28T05:15:36Z

Test output now looks like (using nextest)

$ LANG=en_US.iso88591 cargo nextest run try_verify_against_date_command --no-capture
   Compiling chrono v0.4.24 (/tmp/chrono2)
    Finished test [unoptimized + debuginfo] target(s) in 0.36s
    Starting 2 tests across 3 binaries (181 skipped)
       START             chrono::dateutils try_verify_against_date_command

running 1 test
LANG: "en_US.iso88591"
command: "/usr/bin/date" --version
stdout: "date (GNU coreutils) 8.32\nCopyright (C) 2020 Free Software Foundation, Inc.\nLicense GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.\nThis is free software: you are free to change and redistribute it.\nThere is NO WARRANTY, to the extent permitted by law.\n\nWritten by David MacKenzie.\n"
stderr: ""
Run command "/usr/bin/date" for every hour from 1975 to 2078, skipping some years...
at year 1976...
at year 1977...
at year 2020...
at year 2021...
at year 2022...
at year 2073...
at year 2074...
at year 2075...
at year 2076...
at year 2077...
Command "/usr/bin/date" was run 96432 times
test try_verify_against_date_command ... ok

Print progress messages for human users watching this long-running test `try_verify_against_date_command`.

pitdicker

Just for fun i tried nextest, it looks cool.

Copying your invocation it fails for me locally:

$ LANG=en_US.iso88591 cargo nextest run try_verify_against_date_command --no-capture
    Finished test [unoptimized + debuginfo] target(s) in 0.05s
    Starting 2 tests across 3 binaries (181 skipped)
       START             chrono::dateutils try_verify_against_date_command

running 1 test
        SLOW [> 60.000s] chrono::dateutils try_verify_against_date_command
test try_verify_against_date_command has been running for over 60 seconds
test try_verify_against_date_command ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1 filtered out; finished in 100.50s

        PASS [ 100.504s] chrono::dateutils try_verify_against_date_command
       START             chrono::dateutils try_verify_against_date_command_format

running 1 test
thread 'try_verify_against_date_command_format' panicked at 'assertion failed: `(left == right)`
  left: `"d01 D01/01/70 F1970-01-01 H12 I12 j001 k12 l12 m01 M11 S13 T12:11:13 u4 U00 w4 W00 X12:11:13 PM y70 Y1970 z+01:00\n"`,
 right: `"d01 D01/01/70 F1970-01-01 H12 I12 j001 k12 l12 m01 M11 S13 T12:11:13 u4 U00 w4 W00 X12:11:13 y70 Y1970 z+01:00\n"`', tests/dateutils.rs:121:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
test try_verify_against_date_command_format ... FAILED

failures:

failures:
    try_verify_against_date_command_format

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 1 filtered out; finished in 0.00s

        FAIL [   0.007s] chrono::dateutils try_verify_against_date_command_format
   Canceling due to test failure: 0 tests still running
------------
     Summary [ 100.511s] 2 tests run: 1 passed (1 slow), 1 failed, 181 skipped
        FAIL [   0.007s] chrono::dateutils try_verify_against_date_command_format
error: test run failed

Probably just another case of #1060?

tests/dateutils.rs

jtmoon79 · 2023-05-28T23:47:57Z

Just for fun i tried nextest, it looks cool.

Yeah, nextest is a really nice "drop in" improvement over built-in test. 👍

jtmoon79 · 2023-05-29T01:06:15Z

Copying your invocation it fails for me locally:
...
Probably just another case of #1060?

Yep.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [chrono](https://github.com/chronotope/chrono) | dependencies | patch | `0.4.24` -> `0.4.26` | --- ### Release Notes <details> <summary>chronotope/chrono</summary> ### [`v0.4.26`](https://github.com/chronotope/chrono/releases/tag/v0.4.26): 0.4.26 [Compare Source](chronotope/chrono@v0.4.25...v0.4.26) The changes from [#807](chronotope/chrono#807) we merged for 0.4.25 unfortunately restricted parsing in a way that was incompatible with earlier 0.4.x releases. We reverted this in [#1113](chronotope/chrono#1113). A small amount of other changes were merged since. - Update README ([#1111](chronotope/chrono#1111), thanks to [@pitdicker](https://github.com/pitdicker)) - Revert backport of [#807](chronotope/chrono#807) ([#1113](chronotope/chrono#1113), thanks to [@pitdicker](https://github.com/pitdicker)) - Update to 2021 edition ([#1109](chronotope/chrono#1109), thanks to [@tottoto](https://github.com/tottoto)) - Fix `DurationRound` panics from issue [#1010](chronotope/chrono#1010) ([#1093](chronotope/chrono#1093), thanks to [@pitdicker](https://github.com/pitdicker)) - tests: date path consolidate (branch 0.4.x) ([#1090](chronotope/chrono#1090), thanks to [@jtmoon79](https://github.com/jtmoon79)) - Parse tests nanosecond bare dot (branch 0.4.x) ([#1098](chronotope/chrono#1098), thanks to [@jtmoon79](https://github.com/jtmoon79)) - yamllint cleanup lint.yml test.yml ([#1102](chronotope/chrono#1102), thanks to [@jtmoon79](https://github.com/jtmoon79)) - Remove num-iter dependency ([#1107](chronotope/chrono#1107), thanks to [@tottoto](https://github.com/tottoto)) Thanks on behalf of the chrono team ([@djc](https://github.com/djc) and [@esheppa](https://github.com/esheppa)) to all contributors! ### [`v0.4.25`](https://github.com/chronotope/chrono/releases/tag/v0.4.25): 0.4.25 [Compare Source](chronotope/chrono@v0.4.24...v0.4.25) Time for another maintenance release. This release bumps the MSRV to 1.56; given MSRV bumps in chrono's dependencies (notably for syn 2), we felt that it no longer made sense to support any older versions. Feedback welcome in our issue tracker! ##### Additions - Bump the MSRV to 1.56 ([#1053](chronotope/chrono#1053)) - Apply comments from MSRV bump ([#1026](chronotope/chrono#1026), thanks to [@pitdicker](https://github.com/pitdicker)) - Remove num-integer dependency ([#1037](chronotope/chrono#1037), thanks to [@pitdicker](https://github.com/pitdicker)) - Add `NaiveDateTime::and_utc()` method ([#952](chronotope/chrono#952), thanks to [@klnusbaum](https://github.com/klnusbaum)) - derive `Hash` for most pub types that also derive `PartialEq` ([#938](chronotope/chrono#938), thanks to [@bruceg](https://github.com/bruceg)) - Add `parse_and_remainder()` methods ([#1011](chronotope/chrono#1011), thanks to [@pitdicker](https://github.com/pitdicker)) - Add `DateTime::fix_offset()` ([#1030](chronotope/chrono#1030), thanks to [@pitdicker](https://github.com/pitdicker)) - Add `#[track_caller]` to `LocalResult::unwrap` ([#1046](chronotope/chrono#1046), thanks to [@pitdicker](https://github.com/pitdicker)) - Add `#[must_use]` to some methods ([#1007](chronotope/chrono#1007), thanks to [@aceArt-GmbH](https://github.com/aceArt-GmbH)) - Implement `PartialOrd` for `Month` ([#999](chronotope/chrono#999), thanks to [@Munksgaard](https://github.com/Munksgaard)) - Add `impl From<NaiveDateTime> for NaiveDate` ([#1012](chronotope/chrono#1012), thanks to [@pezcore](https://github.com/pezcore)) - Extract timezone info from tzdata file on Android ([#978](chronotope/chrono#978), thanks to [@RumovZ](https://github.com/RumovZ)) ##### Fixes - Prevent string slicing inside char boundaries ([#1024](chronotope/chrono#1024), thanks to [@pitdicker](https://github.com/pitdicker)) - fix IsoWeek so that its flags are always correct ([#991](chronotope/chrono#991), thanks to [@moshevds](https://github.com/moshevds)) - Fix out-of-range panic in `NaiveWeek::last_day` ([#1070](chronotope/chrono#1070), thanks to [@pitdicker](https://github.com/pitdicker)) - Use correct offset in conversion from `Local` to `FixedOffset` ([#1041](chronotope/chrono#1041), thanks to [@pitdicker](https://github.com/pitdicker)) - Fix military timezones in RFC 2822 parsing ([#1013](chronotope/chrono#1013), thanks to [@pitdicker](https://github.com/pitdicker)) - Guard against overflow in NaiveDate::with_\*0 methods ([#1023](chronotope/chrono#1023), thanks to [@pitdicker](https://github.com/pitdicker)) - Fix panic in from_num_days_from_ce_opt ([#1052](chronotope/chrono#1052), thanks to [@pitdicker](https://github.com/pitdicker)) ##### Refactoring - Rely on std for getting local time offset ([#1072](chronotope/chrono#1072), thanks to [@pitdicker](https://github.com/pitdicker)) - Make functions in internals const ([#1043](chronotope/chrono#1043), thanks to [@pitdicker](https://github.com/pitdicker)) - Refactor windows module in `Local` ([#992](chronotope/chrono#992), thanks to [@nekevss](https://github.com/nekevss)) - Simplify from_timestamp_millis, from_timestamp_micros ([#1032](chronotope/chrono#1032), thanks to [@pitdicker](https://github.com/pitdicker)) - Backport [#983](chronotope/chrono#983) and [#1000](chronotope/chrono#1000) ([#1063](chronotope/chrono#1063), thanks to [@pitdicker](https://github.com/pitdicker)) ##### Documentation - Backport documentation improvements ([#1066](chronotope/chrono#1066), thanks to [@pitdicker](https://github.com/pitdicker)) - Add documentation for %Z quirk ([#1051](chronotope/chrono#1051), thanks to [@campbellcole](https://github.com/campbellcole)) - Add an example to Weekday ([#1019](chronotope/chrono#1019), thanks to [@pitdicker](https://github.com/pitdicker)) ##### Internal improvements - Gate test on `clock` feature ([#1061](chronotope/chrono#1061), thanks to [@pitdicker](https://github.com/pitdicker)) - CI: Also run tests with `--no-default-features` ([#1059](chronotope/chrono#1059), thanks to [@pitdicker](https://github.com/pitdicker)) - Prevent `bench_year_flags_from_year` from being optimized out ([#1034](chronotope/chrono#1034), thanks to [@pitdicker](https://github.com/pitdicker)) - Fix test_leap_second during DST transition ([#1064](chronotope/chrono#1064), thanks to [@pitdicker](https://github.com/pitdicker)) - Fix warnings when running tests on Windows ([#1038](chronotope/chrono#1038), thanks to [@pitdicker](https://github.com/pitdicker)) - Fix tests on AIX ([#1028](chronotope/chrono#1028), thanks to [@ecnelises](https://github.com/ecnelises)) - Fix doctest warnings, remove mention of deprecated methods from main doc ([#1081](chronotope/chrono#1081), thanks to [@pitdicker](https://github.com/pitdicker)) - Reformat `test_datetime_parse_from_str` ([#1078](chronotope/chrono#1078), thanks to [@pitdicker](https://github.com/pitdicker)) - GitHub yml shell `set -eux`, use bash ([#1103](chronotope/chrono#1103), thanks to [@jtmoon79](https://github.com/jtmoon79)) - test: explicitly set `LANG` to `c` in gnu `date` ([#1089](chronotope/chrono#1089), thanks to [@scarf005](https://github.com/scarf005)) - Switch test to `TryFrom` ([#1086](chronotope/chrono#1086), thanks to [@pitdicker](https://github.com/pitdicker)) - Add test for issue 551 ([#1020](chronotope/chrono#1020), thanks to [@pitdicker](https://github.com/pitdicker)) - RFC 2822 single-letter obsolete tests ([#1014](chronotope/chrono#1014), thanks to [@jtmoon79](https://github.com/jtmoon79)) - \[CI] Lint Windows target and documentation links ([#1062](chronotope/chrono#1062), thanks to [@pitdicker](https://github.com/pitdicker)) - add test_issue\_866 ([#1077](chronotope/chrono#1077), thanks to [@jtmoon79](https://github.com/jtmoon79)) - Remove AUTHORS metadata ([#1074](chronotope/chrono#1074)) On behalf of [@djc](https://github.com/djc) and [@esheppa](https://github.com/esheppa), thanks to all contributors! </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1909 Reviewed-by: crapStone <crapstone@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

consolidate path to date

861ea38

jtmoon79 force-pushed the date_path_consolidate branch 3 times, most recently from c722d61 to 694249d Compare May 28, 2023 05:00

jtmoon79 force-pushed the date_path_consolidate branch from 694249d to f6c1f95 Compare May 28, 2023 05:02

jtmoon79 force-pushed the date_path_consolidate branch 2 times, most recently from 76a2f99 to c81c1e8 Compare May 28, 2023 05:19

try_verify_against_date_command NFC print progress messages

c81c1e8

Print progress messages for human users watching this long-running test `try_verify_against_date_command`.

jtmoon79 marked this pull request as ready for review May 28, 2023 05:39

jtmoon79 changed the title ~~Date path consolidate~~ tests: date path consolidate May 28, 2023

jtmoon79 changed the title ~~tests: date path consolidate~~ tests: date path consolidate (branch 0.4.x) May 28, 2023

pitdicker reviewed May 28, 2023

View reviewed changes

tests/dateutils.rs Show resolved Hide resolved

tests/dateutils.rs Show resolved Hide resolved

djc added the waiting-on-review label May 28, 2023

djc approved these changes May 30, 2023

View reviewed changes

djc merged commit e41451d into chronotope:0.4.x May 30, 2023
32 checks passed

pitdicker mentioned this pull request Jun 5, 2023

Fix dead code error when running dateutils test on Windows #1125

Merged

jtmoon79 mentioned this pull request Sep 25, 2023

tests calling date command set env LC_ALL #1315

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tests: date path consolidate (branch 0.4.x) #1090

tests: date path consolidate (branch 0.4.x) #1090

jtmoon79 commented May 28, 2023 •

edited

jtmoon79 commented May 28, 2023

jtmoon79 commented May 28, 2023

pitdicker left a comment

jtmoon79 commented May 28, 2023

jtmoon79 commented May 29, 2023 •

edited

tests: date path consolidate (branch 0.4.x) #1090

tests: date path consolidate (branch 0.4.x) #1090

Conversation

jtmoon79 commented May 28, 2023 • edited

jtmoon79 commented May 28, 2023

jtmoon79 commented May 28, 2023

pitdicker left a comment

Choose a reason for hiding this comment

jtmoon79 commented May 28, 2023

jtmoon79 commented May 29, 2023 • edited

jtmoon79 commented May 28, 2023 •

edited

jtmoon79 commented May 29, 2023 •

edited