Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run publish-action script as afterShipIt hook #877

Merged
merged 2 commits into from
Dec 22, 2023

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Dec 18, 2023

Don't run publish-action on every merge to main, but only when shipIt has run (which depends on the release label being present on the PR).

This should prevent another situation where the GitHub Action is released with code that isn't actually supposed to be released yet (merged to main with the skip-release label).

📦 Published PR as canary version: 10.1.1--canary.877.7264235665.0

✨ Test out this PR locally via:

npm install chromatic@10.1.1--canary.877.7264235665.0
# or 
yarn add chromatic@10.1.1--canary.877.7264235665.0

@ghengeveld ghengeveld added patch Auto: Increment the patch version when merged skip-release Auto: Preserve the current version when merged labels Dec 19, 2023
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@andrewortwein andrewortwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢🪝👍🏻

@ghengeveld ghengeveld added this pull request to the merge queue Dec 22, 2023
Merged via the queue into main with commit 175f58b Dec 22, 2023
20 checks passed
@ghengeveld ghengeveld deleted the publish-action-after-shipit branch December 22, 2023 12:10
@ghengeveld
Copy link
Member Author

🚀 PR was released in v10.2.1 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged released Verdict: This issue/pull request has been released skip-release Auto: Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants