Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BLD] add lint workflow #2045

Merged
merged 2 commits into from
Apr 23, 2024
Merged

[BLD] add lint workflow #2045

merged 2 commits into from
Apr 23, 2024

Conversation

codetheweb
Copy link
Contributor

@codetheweb codetheweb commented Apr 23, 2024

Currently, this will run in CI but never error. There's 80-90 files that need to be (automatically) updated, so I figured I'd do that in a separate PR to reduce noise.

See https://github.com/chroma-core/chroma/actions/runs/8805438845/job/24168001018?pr=2045 for an example workflow run.

Currently, this will run in CI but never error. There's 80-90 files that need to be (automatically) updated, so I figured I'd do that in a separate PR to reduce noise.
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@codetheweb codetheweb marked this pull request as ready for review April 23, 2024 18:32
@HammadB
Copy link
Collaborator

HammadB commented Apr 23, 2024

thanks

@codetheweb codetheweb merged commit 5d909d4 into main Apr 23, 2024
120 checks passed
@codetheweb codetheweb deleted the feat-lint-workflow branch April 23, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants