Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix JS client regression #2026

Merged
merged 4 commits into from
Apr 19, 2024

Conversation

ibratoev
Copy link
Contributor

Fix regression that stopped running the JS client unit tests during CI.

Both regressions are from a large PR: #1970.

Fix regression that stopped running the JS client unit tests during CI.

Both regressions are from a large PR: chroma-core#1970.
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor

@tazarov tazarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you @ibratoev !!! Good catch

@ibratoev
Copy link
Contributor Author

ibratoev commented Apr 18, 2024

It seems a GO test failed. I looked into the test and the issue is that in the GO metastore collection tests, a particular order for collections is expected. The collections are currently returned ordered by id which is UUID -> random. This makes the test flaky and should fail every second run.

I will prepare a quick fix.

Copy link
Member

@beggers beggers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ibratoev ! This was a miss on my part -- I appreciate the thoroughness.

The Golang tests are flaky right now and we're working on them. I'm happy to merge this without them.

@beggers beggers merged commit e3d2b8a into chroma-core:main Apr 19, 2024
118 of 119 checks passed
@ibratoev ibratoev deleted the ib/fix-js-client-tests branch April 19, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants