Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] manifest needs updating (optional) #24

Open
ghost opened this issue Apr 7, 2022 · 0 comments
Open

[feature request] manifest needs updating (optional) #24

ghost opened this issue Apr 7, 2022 · 0 comments

Comments

@ghost
Copy link

ghost commented Apr 7, 2022

currently
<?xml version='1.0' encoding='UTF-8' standalone='yes'?>
<assembly xmlns='urn:schemas-microsoft-com:asm.v1' manifestVersion='1.0'>
  <trustInfo xmlns="urn:schemas-microsoft-com:asm.v3">
    <security>
      <requestedPrivileges>
        <requestedExecutionLevel level='asInvoker' uiAccess='false' />
      </requestedPrivileges>
    </security>
  </trustInfo>
  <dependency>
    <dependentAssembly>
      <assemblyIdentity type='win32' name='Microsoft.Windows.Common-Controls' version='6.0.0.0' processorArchitecture='*' publicKeyToken='6595b64144ccf1df' language='*' />
    </dependentAssembly>
  </dependency>
</assembly>

should probably include this to avoid vista virtualization mode:

<compatibility xmlns="urn:schemas-microsoft-com:compatibility.v1"> <!-- without it, apps will run in windows vista compatibility in windows 7.   https://docs.microsoft.com/en-us/windows/win32/sbscs/application-manifests#compatibility --> 
    <application> 
      <supportedOS Id="{8e0f7a12-bfb3-4fe8-b9a5-48fd50a15a9a}" /> <!-- Windows 10/11  /  Windows Server 2016/2019  --> 
      <supportedOS Id="{1f676c76-80e1-4239-95bb-83d0f6d0da78}" /> <!-- Windows 8.1    /  Windows Server 2012 R2    --> 
      <supportedOS Id="{4a2f28e3-53b9-4441-ba9c-d69d4a4a6e38}" /> <!-- Windows 8      /  Windows Server 2012       --> 
      <supportedOS Id="{35138b9a-5d96-4fbd-8e2d-a2440225f93a}" /> <!-- Windows 7      /  Windows Server 2008 R2    --> 
      <supportedOS Id="{e2011457-1546-43c5-a5fe-008deee3d3f0}" /> <!-- Windows Vista  /  Windows Server 2008       --> 
    </application> 
  </compatibility> 

https://github.com/eladkarako/manifest/blob/master/example_manifests/generic_with_info.manifest#L41-L49


and optionally longPathAware (no actual code change needed),
to remove path length limitations on Windows 10 (that a user had opt-in with registry patch) and Windows 11 (enabled by default for all users).

no actual code change is needed,
if effects CopyFileW, CopyFile2, CopyFileExW, CreateFileW, CreateFile2, CreateHardLinkW, CreateSymbolicLinkW, DeleteFileW, FindFirstFileW, FindFirstFileExW, FindNextFileW, GetFileAttributesW, GetFileAttributesExW, SetFileAttributesW, GetFullPathNameW, GetLongPathNameW, MoveFileW, MoveFileExW, MoveFileWithProgressW, ReplaceFileW, SearchPathW, FindFirstFileNameW, FindNextFileNameW, FindFirstStreamW, FindNextStreamW, GetCompressedFileSizeW, GetFinalPathNameByHandleW

https://github.com/eladkarako/manifest/blob/master/example_manifests/generic_with_info.manifest#L27

https://docs.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=cmd#enable-long-paths-in-windows-10-version-1607-and-later


this is optional (for GUI), normally I would have include DPI awareness too to make the text extra sharp, I use higher DPI screens and text usually looks blurred to me unless the manifest has those values. sometimes it moves controls around so I (add in my stuff) GDI scaling which only render free text (textarea elements) but not labels and controls. no actual code change is needed (just manifest updating).

https://github.com/eladkarako/manifest/blob/master/example_manifests/generic_with_info.manifest#L22

https://github.com/eladkarako/manifest/blob/master/example_manifests/generic_with_info.manifest#L26


thanks for a pretty awesome software

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants