Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deterministic FibonacciLFSR reductions #4688

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Deterministic FibonacciLFSR reductions #4688

merged 1 commit into from
Feb 13, 2025
+1 −1

Conversation

jerryz123
Copy link
Contributor

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)
  • API modification
  • API deprecation
  • Backend code generation
  • Performance improvement
  • Bugfix
  • Documentation or website-related
  • Dependency update
  • Internal or build-related (includes code refactoring/cleanup)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).
  • Rebase: You will rebase the PR onto master and it will be merged with a merge commit.

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash) and clean up the commit message.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

Sorry, something went wrong.

@jerryz123
Enforce deterministic FibonacciLFSR reductions

Unverified

The email in this signature doesn’t match the committer email.
GPG key ID: 7DEE1D789507D6CD
Learn about vigilant mode
Loading
Loading status checks…
bdb07e1
@jerryz123 jerryz123 changed the title eterministic FibonacciLFSR reductions Deterministic FibonacciLFSR reductions Feb 13, 2025
@seldridge seldridge added the Bugfix Fixes a bug, will be included in release notes label Feb 13, 2025
seldridge
seldridge approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Notably, this should have only been FIRRTL output stability and not anything functional, right?

@seldridge
Copy link
Member

I also checked the Galois formulation and that doesn't appear to have this style of instability.

@jerryz123
Copy link
Contributor Author

Yeah its just a FIRRTL consistency issue.

@seldridge seldridge enabled auto-merge (squash) February 13, 2025 23:25
@seldridge seldridge merged commit 63b129d into chipsalliance:main Feb 13, 2025
17 of 18 checks passed
@jackkoenig jackkoenig added this to the 5.x milestone Feb 14, 2025
@mergify mergify bot added the Backported This PR has been backported label Feb 14, 2025
@jackkoenig
Copy link
Contributor

@Mergifyio refresh

chiselbot pushed a commit that referenced this pull request Feb 14, 2025
@jerryz123 @chiselbot
Enforce deterministic FibonacciLFSR reductions (#4688)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
c7cb3fd 
(cherry picked from commit 63b129d)
chiselbot pushed a commit that referenced this pull request Feb 14, 2025
@jerryz123 @chiselbot
Enforce deterministic FibonacciLFSR reductions (#4688)

Unverified

The email in this signature doesn’t match the committer email.
GPG key ID: 7DEE1D789507D6CD
Learn about vigilant mode
Loading
Loading status checks…
f992fa2 
(cherry picked from commit 63b129d)
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 14, 2025

refresh

✅ Pull request refreshed

This was referenced Feb 14, 2025
Merged
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 14, 2025

backport

✅ Backports have been created

chiselbot added a commit that referenced this pull request Feb 14, 2025
@chiselbot @jerryz123
Enforce deterministic FibonacciLFSR reductions (#4688) (#4689)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
e065712 
(cherry picked from commit 63b129d)

Co-authored-by: Jerry Zhao <jerryz123@berkeley.edu>
chiselbot added a commit that referenced this pull request Feb 14, 2025
@chiselbot @jerryz123
Enforce deterministic FibonacciLFSR reductions (#4688) (#4690)
Loading
Loading status checks…
43d9868 
(cherry picked from commit 63b129d)

Co-authored-by: Jerry Zhao <jerryz123@berkeley.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seldridge seldridge

Assignees
No one assigned
Labels
Backported This PR has been backported Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Milestone
5.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jerryz123 @seldridge @jackkoenig