Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix up extra waveform dump behavior in svsim #4592

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

Emin017
Copy link
Contributor

@Emin017 Emin017 commented Jan 5, 2025

When added require statement in ChiselSim/svsim, the delay value will be set to 0, which will cause an extra dump waveform behavior. So we only call eval_step once to update the design model.

This will fix #4516.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

Sorry, something went wrong.

@Emin017 Emin017 changed the title fix: use explicit eval_step when run_simulation delay value is zero fix: use explicit eval_step when run_simulation delay value is zero in svsim Jan 5, 2025
When added require statement in ChiselSim/svsim, the delay value will be
set to 0, which will cause an extra dump waveform behavior. So we only
call `eval_step` once to update the design model
@Emin017 Emin017 force-pushed the fix-extra-waveform-dump branch from f6ca175 to 44dac09 Compare January 5, 2025 03:04
@Emin017 Emin017 changed the title fix: use explicit eval_step when run_simulation delay value is zero in svsim fix up extra waveform dump behavior in svsim Jan 5, 2025
@jackkoenig jackkoenig added the Bugfix Fixes a bug, will be included in release notes label Jan 7, 2025
@jackkoenig jackkoenig added this to the 6.x milestone Jan 7, 2025
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jackkoenig jackkoenig merged commit 3380196 into chipsalliance:main Jan 7, 2025
15 of 16 checks passed
@mergify mergify bot added the Backported This PR has been backported label Jan 7, 2025
mergify bot pushed a commit that referenced this pull request Jan 7, 2025
When added require statement in ChiselSim/svsim, the delay value will be
set to 0, which will cause an extra dump waveform behavior. So we only
call `eval_step` once to update the design model

(cherry picked from commit 3380196)
chiselbot pushed a commit that referenced this pull request Jan 7, 2025

Verified

This commit was signed with the committer’s verified signature.
yordis Yordis Prieto
When added require statement in ChiselSim/svsim, the delay value will be
set to 0, which will cause an extra dump waveform behavior. So we only
call `eval_step` once to update the design model

(cherry picked from commit 3380196)

Co-authored-by: qiming chu <cchuqiming@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported This PR has been backported Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ChiselSim: vcd shows clock=1 for threes consecutive time steps
2 participants