Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grab workflow python version from pyproject.toml #74

Closed
nx10 opened this issue Dec 7, 2023 · 4 comments
Closed

Grab workflow python version from pyproject.toml #74

nx10 opened this issue Dec 7, 2023 · 4 comments

Comments

@nx10
Copy link
Contributor

nx10 commented Dec 7, 2023

This https://github.com/cmi-dair/template-python-repository/blob/70290986abd983766d915c39c47e408b180959d8/.github/workflows/test.yaml#L18

@ReinderVosDeWael
Copy link
Contributor

How do we want this to act with dynamic versions (e.g. >3.9)

@nx10
Copy link
Contributor Author

nx10 commented Dec 7, 2023

Hmm it seems like setup-python already supports it? We should try just removing the python-version field

@nx10
Copy link
Contributor Author

nx10 commented Dec 7, 2023

Independently from that, that field supports semver ranges so we could just copy it in there

@nx10
Copy link
Contributor Author

nx10 commented Dec 8, 2023

Fixed via 4ac72b5

@nx10 nx10 closed this as completed Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants