-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regexp: violation pointing to line 0 while other Checks count first line as 1 #14064
Comments
I think it should be "bug" and we consider "breaking compatibility" for config in most cases, this is change in behavior. |
romani
pushed a commit
to suniti0804/checkstyle
that referenced
this issue
Nov 26, 2023
romani
pushed a commit
to suniti0804/checkstyle
that referenced
this issue
Nov 30, 2023
suniti0804
added a commit
to suniti0804/checkstyle
that referenced
this issue
Dec 2, 2023
suniti0804
added a commit
to suniti0804/checkstyle
that referenced
this issue
Dec 4, 2023
rnveach
pushed a commit
that referenced
this issue
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://checkstyle.org/checks/regexp/regexp.html#Regexp
problem is detected at #14057 and blocks it as test suite can not accept line 0 as expected.
example for other Check that shows that line number is 1
prove in code that line length starts from 1:
checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/api/FileText.java
Lines 279 to 280 in 5509746
Expected:
[ERROR] /var/tmp/Test.java:1: Required pattern '// This code is copyrighted' missing in file. [Regexp]
The text was updated successfully, but these errors were encountered: