Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc for UnusedImports #13007

Closed
romani opened this issue Apr 19, 2023 · 2 comments
Closed

Update doc for UnusedImports #13007

romani opened this issue Apr 19, 2023 · 2 comments

Comments

@romani
Copy link
Member

romani commented Apr 19, 2023

https://checkstyle.org/config_imports.html#UnusedImports

Add example for each existing config AND for each property to show what code is ok and what code cause violation.

A good example is https://checkstyle.org/config_naming.html#AbstractClassName.

Look at referenced commits of #5832, to see what and how should be changed in code.

Please play with module/check by means of https://checkstyle.org/cmdline.html to understand how it works.

PLEASE READ https://github.com/checkstyle/checkstyle/wiki/Good-practice-on-how-to-update-examples

There should be two examples: for default and for property with not default value. Both examples should have same java snippet and only trailing comments changing to mark where violation is happening.

@TanayMorakhia
Copy link
Contributor

I am on it.

TanayMorakhia added a commit to TanayMorakhia/checkstyle that referenced this issue Apr 22, 2023
TanayMorakhia added a commit to TanayMorakhia/checkstyle that referenced this issue Apr 23, 2023
TanayMorakhia added a commit to TanayMorakhia/checkstyle that referenced this issue Apr 23, 2023
TanayMorakhia added a commit to TanayMorakhia/checkstyle that referenced this issue Apr 23, 2023
TanayMorakhia added a commit to TanayMorakhia/checkstyle that referenced this issue Apr 23, 2023
TanayMorakhia added a commit to TanayMorakhia/checkstyle that referenced this issue Apr 25, 2023
TanayMorakhia added a commit to TanayMorakhia/checkstyle that referenced this issue Apr 25, 2023
TanayMorakhia added a commit to TanayMorakhia/checkstyle that referenced this issue Apr 27, 2023
TanayMorakhia added a commit to TanayMorakhia/checkstyle that referenced this issue Apr 30, 2023
TanayMorakhia added a commit to TanayMorakhia/checkstyle that referenced this issue Apr 30, 2023
TanayMorakhia added a commit to TanayMorakhia/checkstyle that referenced this issue Apr 30, 2023
romani pushed a commit to TanayMorakhia/checkstyle that referenced this issue May 2, 2023
TanayMorakhia added a commit to TanayMorakhia/checkstyle that referenced this issue May 16, 2023
TanayMorakhia added a commit to TanayMorakhia/checkstyle that referenced this issue May 16, 2023
TanayMorakhia added a commit to TanayMorakhia/checkstyle that referenced this issue May 17, 2023
TanayMorakhia added a commit to TanayMorakhia/checkstyle that referenced this issue May 17, 2023
TanayMorakhia added a commit to TanayMorakhia/checkstyle that referenced this issue May 18, 2023
@romani
Copy link
Member Author

romani commented May 18, 2023

Fix is merged

@romani romani closed this as completed May 18, 2023
@github-actions github-actions bot added this to the 10.12.0 milestone May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants