Pull #12857: Make twitter-releasenotes job depend on update-github-page

[stoyanK7]

Resolves twitter failure in release run: https://github.com/checkstyle/checkstyle/actions/runs/4438465653
Twitter job: https://github.com/checkstyle/checkstyle/actions/runs/4438465653/jobs/7790124616#step:4:124

TARGET_RELEASE_INDEX=
PREVIOUS_RELEASE_INDEX=1

Release on my fork: https://github.com/stoyanK7/checkstyle/actions/runs/4449215620
Twitter job : https://github.com/stoyanK7/checkstyle/actions/runs/4449215620/jobs/7813174923#step:4:125

TARGET_RELEASE_INDEX=0
PREVIOUS_RELEASE_INDEX=1

Twitter releasenotes job should be dependent on update-github-page because it expects the release to be there

checkstyle/.ci/release-publish-releasenotes-twitter.sh

Lines 32 to 40 in b2e5cb2

	curl https://api.github.com/repos/checkstyle/checkstyle/releases \
	-H "Authorization: token $GITHUB_READ_ONLY_TOKEN" \
	-o /var/tmp/cs-releases.json
	TARGET_RELEASE_NUM=$1
	TARGET_RELEASE_INDEX=$(cat /var/tmp/cs-releases.json | \
	jq "[.[].tag_name] | to_entries | .[] | \
	select(.value==\"checkstyle-$TARGET_RELEASE_NUM\") | .key")
	echo TARGET_RELEASE_INDEX="$TARGET_RELEASE_INDEX"

---

What happened in the fail run was that the twitter job ran before the release was on GitHub and it could not find it. GitHub release was created at

Thu, 16 Mar 2023 15:22:11 GMT Creating Github release

but twitter job started pulling releases at

Thu, 16 Mar 2023 15:22:12 GMT   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current

[romani]

Yes, we need this dependency