Create GitHub action to put current milestone on issue of closed PR #12497

romani · 2022-12-03T18:13:33Z

We put milestone manually after we merge PR.

This should be automatic.
https://www.jessesquires.com/blog/2022/08/04/automatically-assign-milestones-with-github-actions/
https://github.com/orgs/community/discussions/26724#discussioncomment-3253107

Or something special for us. As sometimes pull request needs to marked with milestone as it is referred in commit, but it is rare case we can skip it if this is complicated.

rnveach · 2022-12-03T18:23:18Z

It can't be automatic if the issue already has a milestone set. We sometimes have issues that span multiple releases.

romani · 2022-12-03T19:06:27Z

I think it is fine to have latest milestone. Long lasting usually misc issues, user unlikely interested in watching them.

ayush27prasad · 2023-01-25T23:55:39Z

@romani I am working on this issue, could you please assign it to me?

Also, I have a query as the current milestone is 103 so if any PR is merged, it is assigned to this milestone only or the latest milestone be created in future?

romani · 2023-01-26T02:12:03Z

We are not doing assignments, just make comment "I am on it" and got it.

Yes, the are only single milestone active all the time, there are no time when we have two. And all merged should be marked by such single milestone milestone.

romani · 2023-02-04T22:16:29Z

@Kevin222004, can you help with this issue?

Kevin222004 · 2023-02-05T03:45:59Z

I am on it

stoyanK7 · 2023-02-27T17:28:01Z

@Kevin222004 Are you still working on it? I am interested to take it.

Kevin222004 · 2023-02-27T17:34:23Z

@stoyanK7 please take it I am busy with exam till 2march
And then still I have to learn more about this.

Please work on it

stoyanK7 · 2023-02-27T17:35:11Z

Thanks a lot.

On it then.

…of closed PR

rnveach · 2023-03-04T21:39:06Z

Not working at #12797 (comment)
Please note task did not fail. We should fail on any error.

romani · 2023-03-05T02:00:15Z

@stoyanK7, please take a look

stoyanK7 · 2023-03-05T08:01:03Z

@rnveach

We should fail on any error.

From what I remember, --fail-with-body was not available in all images so I didn't even bother adding it: #12451
I will try adding it to see if it is supported now.

https://github.com/checkstyle/checkstyle/actions/runs/4332960192/jobs/7565786160
{
"message": "Resource not accessible by integration",
"documentation_url": "https://docs.github.com/rest/reference/issues#update-an-issue"
}

It seems that the GITHUB_TOKEN does not have sufficient permissions to update the issue milestone which is strange.
We should have the right permissions for this:

checkstyle/.github/workflows/set-milestone-on-referenced-issue.yml

Lines 16 to 18 in bbd4975

    
           permissions: 
        
             issues: write 
        
             pull-requests: write

However, at the Set up job step of the failing job, this is shown:
https://github.com/checkstyle/checkstyle/actions/runs/4332960192/jobs/7565786160#step:1:17

GITHUB_TOKEN Permissions
  Issues: read
  Metadata: read
  PullRequests: read

In my fork runs the permissions are set right:
https://github.com/stoyanK7/checkstyle/actions/runs/4315749586/jobs/7530566547#step:1:16

GITHUB_TOKEN Permissions
  Issues: write
  Metadata: read
  PullRequests: write

Could it be some repository setting or..?

stoyanK7 · 2023-03-05T08:12:09Z

Could it be this? For me, the setting is enabled.

https://docs.github.com/en/organizations/managing-organization-settings/disabling-or-limiting-github-actions-for-your-organization#preventing-github-actions-from-creating-or-approving-pull-requests

Edit: Just tested it. Even with the setting disabled, fork run permissions are correct.
https://github.com/stoyanK7/checkstyle/actions/runs/4335130110/jobs/7569489151#step:1:17

rnveach · 2023-03-05T15:48:31Z

@romani Ping. I have no knowledge here.

romani · 2023-03-05T15:56:02Z

this is might be token or permission that author of PR has or specially limited to avoid outside people to get access to resources.
in Fork all is done by owner, trusted person.

as we have special logic in action ${{ github.event.pull_request.merged == true }} that limits execution a lot, and content is trusty in this case. We should use PAT.

all existing actions for release, executed by maintainers, trusty accounts.

rnveach · 2023-03-05T16:25:44Z

@romani @stoyanK7
https://github.com/checkstyle/checkstyle/actions/workflows/set-milestone-on-referenced-issue.yml
https://github.com/checkstyle/checkstyle/actions/runs/4336909275/jobs/7572544051

Run ./.ci/set-milestone-on-referenced-issue.sh 12799
PULL_REQUEST_NUMBER=12799
Error: Set not empty value to GITHUB_TOKEN environment variable
Error: Process completed with exit code 1.

This looks to be the latest from what I saw. It looks like this runs on the same PR as it was merged from.

stoyanK7 · 2023-03-05T16:27:09Z

@rnveach @romani Is there a PAT secret in the repository secrets? There must be, since it is used in release workflows.

stoyanK7 · 2023-03-05T16:28:46Z

I think the issue comes from the

on:
  pull_request:
    types:
      - closed

Something tells me action should be executed on pushes to master.

romani · 2023-03-05T16:57:55Z

Something tells me action should be executed on pushes to master.

it will be more secure, and probably logical, as we use commit message as source of truth, it does not matter how commit come to master branch, it will be part of next release. The only extra complexity is what range of commits to use for validation.
May be deactivated concurrency and auto cancel will do a job for this action.

stoyanK7 · 2023-03-05T17:32:19Z

@romani

The only extra complexity is what range of commits to use for validation.

Could you explain more?

For sure concurrency has to be deactivated.

auto cancel will do a job for this action.

What do you mean by auto cancel?

romani · 2023-03-05T17:50:12Z

There are cases when one PR is merging two commits, we need to make sure a action will run on both commits.

What do you mean by auto cancel?

checkstyle/.github/workflows/codeql-analysis.yml

Line 19 in e70d421

cancel-in-progress: true

stoyanK7 · 2023-03-05T17:51:06Z

Oh yeah, makes sense. Back on it.

romani · 2023-03-05T23:39:20Z

I think we need to repeat what our release notes builder is doing in iteration of commits. Execute in same way.
What builder see for release, that should be marked by milestone.

Maybe even add this functionality to builder as extra mode.

romani · 2023-03-06T04:34:05Z

https://github.com/checkstyle/checkstyle/actions/runs/4339680750/jobs/7577497529

0s
Run ./.ci/set-milestone-on-referenced-issue.sh [1](https://github.com/checkstyle/checkstyle/actions/runs/4339680750/jobs/7577497529#step:3:1)2775
PULL_REQUEST_NUMBER=12775
Error: Set not empty value to GITHUB_TOKEN environment variable
Error: Process completed with exit code 1

romani · 2023-03-07T02:49:01Z

Fixed by #12801

rnveach · 2023-03-09T13:43:03Z

@stoyanK7 This still seems to be broken.
https://github.com/checkstyle/checkstyle/actions/runs/4369202639/jobs/7642723623#step:3:46

Please review and confirm.

romani · 2023-03-09T16:12:25Z

Yes, if not issue or pull, we should skip such commit

romani added the approved label Dec 3, 2022

stoyanK7 mentioned this issue Feb 28, 2023

Issue #12497: Create GitHub action to put current milestone on issue of closed PR #12782

Merged

romani closed this as completed in #12782 Mar 4, 2023

romani pushed a commit that referenced this issue Mar 4, 2023

Issue #12497: Create GitHub action to put current milestone on issue …

e00da2f

…of closed PR

romani added the miscellaneous label Mar 4, 2023

romani added this to the 10.8.1 milestone Mar 4, 2023

rnveach reopened this Mar 4, 2023

stoyanK7 mentioned this issue Mar 5, 2023

Pull #12799: Switch to PAT secret in set-milestone workflow #12799

Merged

romani closed this as completed Mar 7, 2023

rnveach reopened this Mar 9, 2023

stoyanK7 mentioned this issue Mar 11, 2023

Pull #12821: Make grep always return exit code 0 in set-milestone #12821

Merged

rnveach closed this as completed in #12821 Mar 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create GitHub action to put current milestone on issue of closed PR #12497

Create GitHub action to put current milestone on issue of closed PR #12497

romani commented Dec 3, 2022

rnveach commented Dec 3, 2022

romani commented Dec 3, 2022

ayush27prasad commented Jan 25, 2023 •

edited

romani commented Jan 26, 2023

romani commented Feb 4, 2023

Kevin222004 commented Feb 5, 2023

stoyanK7 commented Feb 27, 2023

Kevin222004 commented Feb 27, 2023

stoyanK7 commented Feb 27, 2023

rnveach commented Mar 4, 2023 •

edited

romani commented Mar 5, 2023

stoyanK7 commented Mar 5, 2023 •

edited

stoyanK7 commented Mar 5, 2023 •

edited

rnveach commented Mar 5, 2023

romani commented Mar 5, 2023 •

edited

rnveach commented Mar 5, 2023 •

edited

stoyanK7 commented Mar 5, 2023 •

edited

stoyanK7 commented Mar 5, 2023 •

edited

romani commented Mar 5, 2023 •

edited

stoyanK7 commented Mar 5, 2023

romani commented Mar 5, 2023

stoyanK7 commented Mar 5, 2023

romani commented Mar 5, 2023 •

edited

romani commented Mar 6, 2023

romani commented Mar 7, 2023

rnveach commented Mar 9, 2023

romani commented Mar 9, 2023

Create GitHub action to put current milestone on issue of closed PR #12497

Create GitHub action to put current milestone on issue of closed PR #12497

Comments

romani commented Dec 3, 2022

rnveach commented Dec 3, 2022

romani commented Dec 3, 2022

ayush27prasad commented Jan 25, 2023 • edited

romani commented Jan 26, 2023

romani commented Feb 4, 2023

Kevin222004 commented Feb 5, 2023

stoyanK7 commented Feb 27, 2023

Kevin222004 commented Feb 27, 2023

stoyanK7 commented Feb 27, 2023

rnveach commented Mar 4, 2023 • edited

romani commented Mar 5, 2023

stoyanK7 commented Mar 5, 2023 • edited

stoyanK7 commented Mar 5, 2023 • edited

rnveach commented Mar 5, 2023

romani commented Mar 5, 2023 • edited

rnveach commented Mar 5, 2023 • edited

stoyanK7 commented Mar 5, 2023 • edited

stoyanK7 commented Mar 5, 2023 • edited

romani commented Mar 5, 2023 • edited

stoyanK7 commented Mar 5, 2023

romani commented Mar 5, 2023

stoyanK7 commented Mar 5, 2023

romani commented Mar 5, 2023 • edited

romani commented Mar 6, 2023

romani commented Mar 7, 2023

rnveach commented Mar 9, 2023

romani commented Mar 9, 2023

ayush27prasad commented Jan 25, 2023 •

edited

rnveach commented Mar 4, 2023 •

edited

stoyanK7 commented Mar 5, 2023 •

edited

stoyanK7 commented Mar 5, 2023 •

edited

romani commented Mar 5, 2023 •

edited

rnveach commented Mar 5, 2023 •

edited

stoyanK7 commented Mar 5, 2023 •

edited

stoyanK7 commented Mar 5, 2023 •

edited

romani commented Mar 5, 2023 •

edited

romani commented Mar 5, 2023 •

edited