Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not using default browser #150

Closed
SunPodder opened this issue Nov 7, 2022 · 4 comments
Closed

Not using default browser #150

SunPodder opened this issue Nov 7, 2022 · 4 comments

Comments

@SunPodder
Copy link

I have firefox installed. Then why does it downloading chromium?

@caarlos0
Copy link
Member

caarlos0 commented Nov 8, 2022

vhs uses go-rod, which only supports chromium

https://github.com/go-rod/rod

@SunPodder
Copy link
Author

Is there any planning to support other browsers in future?

@SunPodder
Copy link
Author

@caarlos0 I have chromium installed this time. Still it's trying to download it.

$ vhs < demo.tape
[launcher.Browser]2023/01/12 10:42:56 try to find the fastest host to download the browser binary
[launcher.Browser]2023/01/12 10:42:56 check https://storage.googleapis.com/chromium-browser-snapshots//1033860/     
[launcher.Browser]2023/01/12 10:42:56 check https://registry.npmmirror.com/-/binary/chromium-browser-snapshots//1033860/
[launcher.Browser]2023/01/12 10:42:56 check https://playwright.azureedge.net/builds/chromium/1033860/chromium-linux-arm64.zip

@bashbunni
Copy link
Member

Hey @SunPodder I saw you asked this on the upstream dependency. I'll let them answer than over on rod as it is not behaviour handled by vhs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants