docs: add client env vars to README #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ayman Bagabas <ayman.bagabas@gmail.com>
|
@azoller1 @richard-kramer does this help clarify the issue you encountered with self-hosting charm + configuring client side options? Let me know if there's anything you think might improve the experience here :) |
4 tasks
Generally yes, this neatly documents all the possible variables. Maybe it is a good idea, to also provide an example for how to configure the client when running the server behind a default https proxy? E.g. set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Related Issues:
closes #209
Notes:
I think this should be mentioned in the Skate docs that you can customize the skate client with these env variables and link back to this section of the Charm docs. Also, not sure how we feel about moving the install instructions, but it felt strange having it so deep into the weeds of Charm cloud.