Improve robustness of argument removal for encode calls
#3802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
changed the title
encode calls
charliermarsh
added a commit
that referenced
this pull request
Mar 29, 2023
PR Check ResultsEcosystem✅ ecosystem check detected no changes. BenchmarkLinuxWindows |
charliermarsh
added a commit
that referenced
this pull request
Mar 29, 2023
bruxisma
pushed a commit
to ixm-one/pytest-cmake-presets
that referenced
this pull request
Apr 5, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) | `^0.0.260` -> `^0.0.261` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.261`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.261) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.260...v0.0.261) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### Rules - \[`flake8-simplify`] Ignore `collapsible-if` violations for `if False:` and `if True:` by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3732 - \[`flake8-pie`] Extend `unncessary-generator-any-all` to set comprehensions by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3824 - \[`flake8-simplify`] Implement `dict-get-with-none-default` (`SIM910`) by [@​kyoto7250](https://togithub.com/kyoto7250) in [astral-sh/ruff#3874 - \[`flake8-annotations`] Additional simple magic return types by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#3805 - \[`flake8-pyi`]: fix PYI015 false positive on assignment of TypeVar & friends by [@​bluetech](https://togithub.com/bluetech) in [astral-sh/ruff#3861 ##### Bug Fixes - Improve robustness of argument removal for `encode` calls by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3802 - Fix SIM222 and SIM223 false positive by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3832 - When checking module visibility, don't check entire ancestry by [@​Hnasar](https://togithub.com/Hnasar) in [astral-sh/ruff#3835 - Improve top-of-file insertions for required imports by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3779 - Use multi-fix semantics for `inplace` removal by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3804 - Flag non-`Name` expressions in `duplicate-isinstance-call` by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3817 - Avoid `unnecessary-comprehension-any-all` for async generators by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3823 - Fix `is_module_name()` and improve perf of `is_identifier()` by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3795 - Allow starred arguments in B030 by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3871 - Support mutually exclusive branches for `B031` by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#3844 - Consider logger candidate from `logging` module only by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#3878 ##### Core - Add import insertion support to autofix capabilities by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3787 - Generate `ImportMap` from module path to imported dependencies by [@​chanman3388](https://togithub.com/chanman3388) in [astral-sh/ruff#3243 ##### Docs - Add documentation for `ruff-action` (GitHub Action!) by [@​brucearctor](https://togithub.com/brucearctor) in [astral-sh/ruff#3857 #### New Contributors - [@​AetherUnbound](https://togithub.com/AetherUnbound) made their first contribution in [astral-sh/ruff#3806 - [@​Hnasar](https://togithub.com/Hnasar) made their first contribution in [astral-sh/ruff#3835 - [@​nvuillam](https://togithub.com/nvuillam) made their first contribution in [astral-sh/ruff#3848 - [@​brucearctor](https://togithub.com/brucearctor) made their first contribution in [astral-sh/ruff#3857 **Full Changelog**: astral-sh/ruff@v0.0.260...v0.0.261 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4zMi4yIiwidXBkYXRlZEluVmVyIjoiMzUuMzIuMiJ9--> Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
renovate bot
added a commit
to allenporter/pyrainbird
that referenced
this pull request
Apr 7, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) | `==0.0.260` -> `==0.0.261` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.261`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.261) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.260...v0.0.261) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### Rules - \[`flake8-simplify`] Ignore `collapsible-if` violations for `if False:` and `if True:` by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3732 - \[`flake8-pie`] Extend `unncessary-generator-any-all` to set comprehensions by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3824 - \[`flake8-simplify`] Implement `dict-get-with-none-default` (`SIM910`) by [@​kyoto7250](https://togithub.com/kyoto7250) in [astral-sh/ruff#3874 - \[`flake8-annotations`] Additional simple magic return types by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#3805 - \[`flake8-pyi`]: fix PYI015 false positive on assignment of TypeVar & friends by [@​bluetech](https://togithub.com/bluetech) in [astral-sh/ruff#3861 ##### Bug Fixes - Improve robustness of argument removal for `encode` calls by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3802 - Fix SIM222 and SIM223 false positive by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3832 - When checking module visibility, don't check entire ancestry by [@​Hnasar](https://togithub.com/Hnasar) in [astral-sh/ruff#3835 - Improve top-of-file insertions for required imports by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3779 - Use multi-fix semantics for `inplace` removal by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3804 - Flag non-`Name` expressions in `duplicate-isinstance-call` by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3817 - Avoid `unnecessary-comprehension-any-all` for async generators by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3823 - Fix `is_module_name()` and improve perf of `is_identifier()` by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3795 - Allow starred arguments in B030 by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3871 - Support mutually exclusive branches for `B031` by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#3844 - Consider logger candidate from `logging` module only by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#3878 ##### Core - Add import insertion support to autofix capabilities by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3787 - Generate `ImportMap` from module path to imported dependencies by [@​chanman3388](https://togithub.com/chanman3388) in [astral-sh/ruff#3243 ##### Docs - Add documentation for `ruff-action` (GitHub Action!) by [@​brucearctor](https://togithub.com/brucearctor) in [astral-sh/ruff#3857 #### New Contributors - [@​AetherUnbound](https://togithub.com/AetherUnbound) made their first contribution in [astral-sh/ruff#3806 - [@​Hnasar](https://togithub.com/Hnasar) made their first contribution in [astral-sh/ruff#3835 - [@​nvuillam](https://togithub.com/nvuillam) made their first contribution in [astral-sh/ruff#3848 - [@​brucearctor](https://togithub.com/brucearctor) made their first contribution in [astral-sh/ruff#3857 **Full Changelog**: astral-sh/ruff@v0.0.260...v0.0.261 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/allenporter/pyrainbird). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4zNC4xIiwidXBkYXRlZEluVmVyIjoiMzUuMzQuMSJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
added a commit
to allenporter/flux-local
that referenced
this pull request
Apr 7, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://togithub.com/charliermarsh/ruff) | `==0.0.260` -> `==0.0.261` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.261`](https://togithub.com/charliermarsh/ruff/releases/tag/v0.0.261) [Compare Source](https://togithub.com/charliermarsh/ruff/compare/v0.0.260...v0.0.261) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### Rules - \[`flake8-simplify`] Ignore `collapsible-if` violations for `if False:` and `if True:` by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3732 - \[`flake8-pie`] Extend `unncessary-generator-any-all` to set comprehensions by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3824 - \[`flake8-simplify`] Implement `dict-get-with-none-default` (`SIM910`) by [@​kyoto7250](https://togithub.com/kyoto7250) in [astral-sh/ruff#3874 - \[`flake8-annotations`] Additional simple magic return types by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#3805 - \[`flake8-pyi`]: fix PYI015 false positive on assignment of TypeVar & friends by [@​bluetech](https://togithub.com/bluetech) in [astral-sh/ruff#3861 ##### Bug Fixes - Improve robustness of argument removal for `encode` calls by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3802 - Fix SIM222 and SIM223 false positive by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3832 - When checking module visibility, don't check entire ancestry by [@​Hnasar](https://togithub.com/Hnasar) in [astral-sh/ruff#3835 - Improve top-of-file insertions for required imports by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3779 - Use multi-fix semantics for `inplace` removal by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3804 - Flag non-`Name` expressions in `duplicate-isinstance-call` by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3817 - Avoid `unnecessary-comprehension-any-all` for async generators by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3823 - Fix `is_module_name()` and improve perf of `is_identifier()` by [@​JonathanPlasse](https://togithub.com/JonathanPlasse) in [astral-sh/ruff#3795 - Allow starred arguments in B030 by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3871 - Support mutually exclusive branches for `B031` by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#3844 - Consider logger candidate from `logging` module only by [@​dhruvmanila](https://togithub.com/dhruvmanila) in [astral-sh/ruff#3878 ##### Core - Add import insertion support to autofix capabilities by [@​charliermarsh](https://togithub.com/charliermarsh) in [astral-sh/ruff#3787 - Generate `ImportMap` from module path to imported dependencies by [@​chanman3388](https://togithub.com/chanman3388) in [astral-sh/ruff#3243 ##### Docs - Add documentation for `ruff-action` (GitHub Action!) by [@​brucearctor](https://togithub.com/brucearctor) in [astral-sh/ruff#3857 #### New Contributors - [@​AetherUnbound](https://togithub.com/AetherUnbound) made their first contribution in [astral-sh/ruff#3806 - [@​Hnasar](https://togithub.com/Hnasar) made their first contribution in [astral-sh/ruff#3835 - [@​nvuillam](https://togithub.com/nvuillam) made their first contribution in [astral-sh/ruff#3848 - [@​brucearctor](https://togithub.com/brucearctor) made their first contribution in [astral-sh/ruff#3857 **Full Changelog**: astral-sh/ruff@v0.0.260...v0.0.261 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/allenporter/flux-local). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4zNC4xIiwidXBkYXRlZEluVmVyIjoiMzUuMzQuMSJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrates
UP012to use our sharedremove_argumenthelper, to replace its buggy argument-removal implementation. Also improves the diagnostic to use a separate suggestion for "Rewrite as a byte string" vs. "Remove the default argument" cases.Closes #3797.